Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output: fix for gcc 4.7 / c++11 destructor noexcept(true) #1432

Conversation

breznak
Copy link
Member

@breznak breznak commented Jul 30, 2018

https://stackoverflow.com/questions/42976461/exception-in-destructor-c
We locally allow throwing an exception from the ~Output destructor.

Fixes: #1000 #1414
Replaces: #1415

@breznak breznak requested a review from lscheinkman July 30, 2018 20:45
@lscheinkman
Copy link
Contributor

@breznak Could you take a look at https://ci.numenta.com/browse/NUP-NGPR-SC-469/log
I think you just need to fix the format. Just run the following command to fix it:

git clang-format upstream/master

@breznak
Copy link
Member Author

breznak commented Jul 30, 2018

Sorry, somehow dupe of #1431

@breznak
Copy link
Member Author

breznak commented Jul 30, 2018

Thanks @lscheinkman , formating done.

Copy link
Contributor

@lscheinkman lscheinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@rhyolight rhyolight merged commit e0e4125 into numenta:master Aug 6, 2018
@breznak breznak deleted the community_fix_c++11_destructors_noexcept branch August 6, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants