-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
factoring out the theme #475
Comments
It sounds great to me. @joelachance what do you think? Any concerns or pitfalls you see here? |
I made a test PR (#476) to make the discussion more concrete. |
@stefanv @jarrodmillman It will be great to get help with maintaining and improving the theme. Don’t hesitate to ping me if you think my input would be useful. |
There are some issues in the current theme that may be ported over, mostly regarding mobile view:
I'm working on these fixes, so once they are done, I can make the changes in #476. |
This seems like a great idea! I think the only thing I'd mention is the idea of being tied to a common theme with other groups. For example, maybe scipy wants square buttons instead of rounded buttons, who decides UX decisions? Are all groups comfortable being apart of a more uniform solution? Maybe everyone is happy doing this, and this really isn't a consideration. I will say I think this is likely much better than relying on whoever is currently supporting the fresh theme. If a bug arises, this seems like a better solution than waiting for someone to pick up tickets over at Fresh. @jarrodmillman, the PR seems good to me! I'm assuming any changes in the partials and layout was ported to scientific python hugo theme (SPHT? lol) I'm quite busy currently and wouldn't be able to pick up tickets ATM, but would be interested in contributing in the future if needed. |
Thanks for your feedback, @joelachance! For now, I suppose the team making the decisions will pretty much be the www.numpy.org team. But I can imagine when projects eventually want diverging styles / features, we could implement those as configuration options and let the default be whatever www.numpy.org uses. We ported all of the non-numpy-specific changes in partials & layouts, and removed some hard-coding of e.g. the project name (now specified in the config). Initially, we didn't want to change too much to ensure that www.numpy.org would continue to render as-is. |
Hello, @stefanv! That makes sense, I do think this is a good direction. |
@stefanv and I recently ported scipy.org to the new numpy.org theme (scipy/scipy.org#413). At first, we just manually copied over the files https://github.com/scientific-python/scipy.org-new/commit/7dda713c97330ff6e2e05cd939f4d919f15cb77c. We started to think about using it for other sites (e.g., I would like to use this theme for https://scientific-python.org and https://networkx.org). So we extracted the numpy.org theme to https://github.com/scientific-python/scientific-python-hugo-theme/ and used it for the new scipy.org site (https://github.com/scientific-python/scipy.org-new/pull/15).
Would you be interested in a PR to this repo to use https://github.com/scientific-python/scientific-python-hugo-theme/? @stefanv and I are willing to help support this theme as part of the https://scientific-python.org project for a few years. We would like to recruit a core developer team to help develop this theme. Would any of you be willing to/interested in being a core developer of https://github.com/scientific-python/scientific-python-hugo-theme/?
How should we proceed? Maybe we should organize a short conference call to discuss how to move forward.
The text was updated successfully, but these errors were encountered: