Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon colors in Science tab of Ecosystem section #478

Closed
MarsBarLee opened this issue Oct 15, 2021 · 7 comments · Fixed by #607
Closed

Change icon colors in Science tab of Ecosystem section #478

MarsBarLee opened this issue Oct 15, 2021 · 7 comments · Fixed by #607
Labels

Comments

@MarsBarLee
Copy link
Contributor

Change the colors of the icons in the Science tab of the Ecosystem section from black to the dark blue used in the rest of the theme, hex color code #013243.

Related to #474. This issue is to help separate the multiple issues mentioned in #474 into their own separate issues. @new-vivek11, would you like to continue with making the color changes?

@ghost
Copy link

ghost commented Oct 15, 2021

@MarsBarLee oh surely I will do it .. just if I can find a more easy reference to all the icons .. then it is just a matter of few clicks for me (using photoshop)

#474

@MarsBarLee
Copy link
Contributor Author

@new-vivek11 You can find the icons in this folder: numpy.org/static/images/content_images/sc_dom_img folder. Let me know if you have any other questions. Thanks!

@ghost
Copy link

ghost commented Oct 15, 2021

@MarsBarLee ok let me change the colors ... Should I upload them here in this thread once I am done with them ?

@MarsBarLee
Copy link
Contributor Author

MarsBarLee commented Oct 15, 2021

@new-vivek11 You make a contribution by making a pull request in this numpy.org repository.

If you're not already familiar with using Git on the command line, you can also make a pull request (PR) using the Github.com web interface.

You can make a fork of numpy.org repository. Then go to your fork and make a new branch. On that branch, you can replace the files with the new ones by deleting the old ones and uploading the new ones (there should be buttons for both 'delete' and 'add files'). Then you make a pull request from your branch to this repository. This will open a new pull request page that will you see here.

By making your own PR, you get contribution recognition to your account! :)

@MarsBarLee
Copy link
Contributor Author

MarsBarLee commented Oct 15, 2021

In the top-right corner of the numpy.org page, click Fork.
image


On your fork, create a new branch by typing the branch name. In this example, you see my fork.
image


On your new branch, go to the numpy.org/static/images/content_images/sc_dom_img folder. In the upper right corner, you can see the 'Add file' button.
In this example, I am on the icons_update branch.
image


If you click on a file, you can also delete it.
image


Hope that helps!

@ghost
Copy link

ghost commented Oct 15, 2021

ok let me finish the conversion process of images (just installed Adobe illustrator to keep them .svg)

@ghost
Copy link

ghost commented Oct 15, 2021

i have made a pull request : #479

not sure whether i did it the right way or not but my guess is that i have done it right (new to pull requests) ... please let me know whether i have done all that i need to do from my side. @MarsBarLee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant