Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs #91

Merged
merged 2 commits into from
Jul 9, 2023
Merged

Docs #91

merged 2 commits into from
Jul 9, 2023

Conversation

roberth
Copy link
Contributor

@roberth roberth commented Jul 9, 2023

I think the checks are decent now, especially with the stubPkgs.
The flakeModule isn't covered by the local checks, but the alternative is adding a dependency, which I don't think is a good trade-off because of it leaking to user lock files, NixOS/nix#7730. I think it's good enough.

@zimbatm
Copy link
Member

zimbatm commented Jul 9, 2023

thanks!

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 3fadb6b into numtide:main Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roberth @zimbatm