-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .Net 8.0 #1320
Add support for .Net 8.0 #1320
Conversation
OsirisTerje
commented
Feb 14, 2023
- Updated to not crash when .net 8 is installed
- Updated building information
src/NUnitEngine/nunit.engine.core/Internal/RuntimeFrameworks/NetCoreFrameworkLocator.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the runner doesn't seem to really do anything with this, is it possible to cherry pick my commit to main from 11 months ago where the dependency was removed completely?
See:
Author: Manfred Brands [email protected]
Date: 11 months ago (31/03/2022 12:15:58)
Commit hash: d5648b9
Child: 100b434
Parent: 0d5ea36
Removed ClrVersion from RuntimeFramework
Decision logic moved to Runtime class.
@manfred-brands I wasn't really aware of this, @CharliePoole made some comments about it, but I didn't know it had been done. Will do this. UPDATE: SORRY: This didn't work out. Too many merges, and ended with 43 compiler errors, and I have no clue what I am actually changing here. It is not possible to cherry-pick only that commit. The class/file Runtime.cs was created March 1st, #a5b701c , and there are others in between which seem to be involved. |