Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RecentFilesService from Engine #906

Merged
merged 1 commit into from
Feb 28, 2021
Merged

Remove RecentFilesService from Engine #906

merged 1 commit into from
Feb 28, 2021

Conversation

CharliePoole
Copy link
Member

Fixes #874

Once reviewed, this will merge into the new dev-4.0 branch, which I set up to hold 4.0 breaking changes.

@CharliePoole CharliePoole requested a review from a team February 28, 2021 04:10
ChrisMaddock
ChrisMaddock approved these changes Feb 28, 2021
View reviewed changes
Copy link
Member

@ChrisMaddock ChrisMaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍 You ok to merge this in after the headers change, Charlie?

@CharliePoole
Copy link
Member Author

Yup. Will do.

@CharliePoole CharliePoole merged commit fc27cf7 into dev-4.0 Feb 28, 2021
@CharliePoole CharliePoole deleted the issue-874 branch February 28, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisMaddock ChrisMaddock ChrisMaddock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CharliePoole @ChrisMaddock