-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Code fix for NUnit2005 does not correctly fix Assert.AreEqual if named parameters are used in unexpected order #712
Comments
I guess we need to add some logic to |
…es that the first argument is expected and the second argument is actual
@mikkelbu I just filed a PR for this! |
@mikkelbu @manfred-brands Can you assign this issue and the corresponding PR to me? |
@Bartleby2718 Done. I'm in the process of reviewing your PR. |
…es that the first argument is expected and the second argument is actual
…#716) * Fix #712: AreEqualClassicModelAssertUsageCodeFix no longer assumes that the first argument is expected and the second argument is actual * Add a new overload for UpdateArguments * Make all code functional but not yet readable/maintainable * Refactoring * Handle out-of-order arguments in all ClassicModelAssertUsageCodeFixes * Add out-of-order test cases to CollectionAssertUsageCodeFixTests * Update all other CodeFixTests, fixing CodeFixes to account for bugs found * Remove an extra whitespace * Code review changes * Omit named parameters for the constraint model * Add test case: two arguments for params in all ClassicAssert tests * Omit named parameters in StringAssertUsageCodeFix * Consistently use WithNameColon Update Tests to remove named parameters * Code review changes * We no longer need HasToleranceValue * We no longer need ComparerParameterIndex * Update param tags for GetInterpolatedMessageArgumentOrDefault --------- Co-authored-by: Manfred Brands <[email protected]>
Given the following (note the order of named parameters)
NUnit.Analyzers
cannot fixNUnit2005
correctly.The above should suffice, but I also created a repo: https://github.com/Bartleby2718/NUnit2005-Assert-AreEqual-repro
The text was updated successfully, but these errors were encountered: