Add DelegateRequiredAnalyzer #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manfred-brands
force-pushed
the
throws
branch
from
ac4e0b8 to
5be3ff3
Compare
|
Now also addresses case 1 of #149 |
manfred-brands
changed the title
mikkelbu
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
Looks great @manfred-brands. I some typos, but that is all. I'm happy to merge this when you are 👍.
src/nunit.analyzers.tests/DelegateRequired/DelegateRequiredAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
src/nunit.analyzers.tests/DelegateRequired/DelegateRequiredCodeFixTests.cs
Outdated
Show resolved
Hide resolved
Apply suggestions from code review Thanks @mikkelbu. I thought I had renamed everything when I changed scope, but forgot the test namespace
manfred-brands
force-pushed
the
throws
branch
from
05524b8 to
ba1d286
Compare
|
Thanks @mikkelbu, I thought I had renamed everything when I extended the scope of the ticket, but forgot the test namespaces. |
mikkelbu
approved these changes
Feb 17, 2021
|
@manfred-brands Thanks for the contribution, I'll merge it now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357
Fixes #149
There is no need to check classic method Assert.Throw etc as the argument definition already specifies a delegate.