Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suppression of type parameters that have notnull constraints #554

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

manfred-brands
Copy link
Member

Fixes #462

@manfred-brands manfred-brands requested a review from mikkelbu June 3, 2023 11:29
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor nitpick (the tests answered the rest :) ). I'm happy to merge when you are 👍


[TestCase("class", "CS8634")]
[TestCase("notnull", "CS8714")]
public void TestIssue462SuppressesMultiple(string constraint, string diagnostic)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally had a question about this in the production code, but this test answered it 👍

@manfred-brands manfred-brands merged commit b34555f into nunit:master Jun 6, 2023
@manfred-brands manfred-brands deleted the issue/462 branch June 6, 2023 09:24
@mikkelbu mikkelbu added this to the Release 3.7 / 2.7 milestone Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiagnosticsSuppress does not suppress CS8634
2 participants