Add support for Assume.That for NUnit2050 #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manfred-brands
force-pushed
the
issue719_NUnit2050_Assume
branch
from
53c5de0 to
d555925
Compare
Bartleby2718
suggested changes
Apr 8, 2024
There was a problem hiding this comment.
https://github.com/nunit/nunit.analyzers/blob/master/documentation/NUnit2050.md?plain=1#L26 should probably be updated to include assume, and it may be explicitly worth mentioning somewhere in that file that everything also applies to Assume.
...eStringFormatToInterpolatableString/UpdateStringFormatToInterpolatableStringAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
...teStringFormatToInterpolatableString/UpdateStringFormatToInterpolatableStringCodeFixTests.cs
Outdated
Show resolved
Hide resolved
...UpdateStringFormatToInterpolatableString/UpdateStringFormatToInterpolatableStringAnalyzer.cs
Show resolved
Hide resolved
manfred-brands
force-pushed
the
issue719_NUnit2050_Assume
branch
from
761c0a8 to
3ba7f33
Compare
mikkelbu
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
LGTM. Thanks for the contribution @manfred-brands and the initial review @Bartleby2718. I've a couple of consistency nitpicks, but I'm happy to merge it when you are
...eStringFormatToInterpolatableString/UpdateStringFormatToInterpolatableStringAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
...eStringFormatToInterpolatableString/UpdateStringFormatToInterpolatableStringAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
...eStringFormatToInterpolatableString/UpdateStringFormatToInterpolatableStringAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
...eStringFormatToInterpolatableString/UpdateStringFormatToInterpolatableStringAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
manfred-brands
force-pushed
the
issue719_NUnit2050_Assume
branch
from
3ba7f33 to
5a7a2ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #719