Fix two bugs: 173 and 174

[nunnatsa]

Description

Bug fix: false positive for func returns error func

The linter triggers a warning for this case:

func errFunc() func() error {
	return func() error {
		return errors.New("error")
	}
}

var _ = Describe("test if issue 174 was solved", func() {
	It("should not trigger", func() {
		Eventually(errFunc()).Should(MatchError(ContainSubstring("error")))
	})
})

The linter fails to identify the actual value as error value.

Fixes #174

Fix bug: ginkgolinter ignores the Error() method

as in:

Expect(func() (int, error) {return 42, nil}()).Error().ToNot(HaveOccurred())

Fixes #173

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Refactoring

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Added test case and related test data
• Update the functional test

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I ran make goimports
• I ran golangci-lint

[github-actions]

Pull Request Test Coverage Report for Build 11781038284

Details

• 19 of 29 (65.52%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.05%) to 77.628%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/gomegahandler/dothandler.go	0	5	0.0%
internal/gomegahandler/namedhandler.go	0	5	0.0%

Totals
Change from base Build 11773770027:	-0.05%
Covered Lines:	2193
Relevant Lines:	2825

---

💛 - Coveralls