Fix bug: false positive warning for typed function calls #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pohly, would you mind to take a look at this fix? |
Pull Request Test Coverage Report for Build 5391259784
💛 - Coveralls |
pohly
reviewed
Jun 27, 2023
ginkgo_linter.go
Outdated
| @@ -371,6 +368,19 @@ func checkAsyncAssertion(pass *analysis.Pass, config types.Config, expr *ast.Cal | |||
| return true | |||
| } | |||
|
|
|||
| func isValidFuncCallInAsync(t gotypes.Type) bool { | |||
There was a problem hiding this comment.
I was initially confused about the FuncCall here. This isn't checking the function call, it's checking the type of the return value of the function call, is it?
Perhaps rename to isValidAsyncValueType?
| func isValidFuncCallInAsync(t gotypes.Type) bool { | ||
| switch t.(type) { | ||
| // allow functions that return function or channel. | ||
| case *gotypes.Signature, *gotypes.Chan, *gotypes.Pointer: |
There was a problem hiding this comment.
Nit: I find the intention easier to read when the return true is here instead of below.
When calling a function that return a type in the async assertion (eventually/constantly) body, if this type is a function, the linter fiels to recognize it and fire a warning. This PR fixes this bug, by checking the underline types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calling a function that return a type in the async assertion (eventually/constantly) body, if this type is a function, the linter fails to recognize it and fire a warning.
This PR fixes this bug, by checking the underline types.
Fixes #91
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
@nunnatsa