[W14-2] FomoFoto #28
Open
[W14-2] FomoFoto #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
Feedback (Week 7; v1.1)Github Project Page
README
Project Page
About Us page
UG/DG feedback will be provided to you in the documents. |
cchj1995
pushed a commit
to cchj1995/addressbook-level4
that referenced
this pull request
Mar 11, 2019
Renamed photos
yonggqiii
pushed a commit
to yonggqiii/main
that referenced
this pull request
Mar 12, 2019
update user guide - delete findtag command
| @Override | ||
| public CommandResult execute(Model model, CommandHistory history) { | ||
| if (this.brightnessValue.isPresent()) { | ||
| seedu.address.model.image.Image initialImage = new seedu.address |
There was a problem hiding this comment.
You can do an import seedu.address.model.image.Image then this will be just Image initialImage = new Image(...)
If you are concerned with the class name clash, you can name your Image class as FFImage.
| private String fileName; | ||
|
|
||
| public CropCommand(int x, int y, int width, int height, String image) { | ||
| xCoord = x; |
There was a problem hiding this comment.
A suggestion to store your coordinates is to store them as tuples, where you can easily if 2 coordinates are equal and access the x and y values as .x or .y.
| throw new ParseException(String.format(MESSAGE_INVALID_TYPE, ImportCommand.MESSAGE_USAGE)); | ||
| } | ||
| } catch (IOException e) { | ||
| System.out.println(e.toString()); |
There was a problem hiding this comment.
Instead of println, you should log it as an error.
Add Reposense to PPP
Edit user guide
Trying to fix addison's face
Fix spelling errors.
Correct grammar in PPP and dev guide
Edit adoc, user guide, developer guide english
Edit grammar in dev guide and sequence diagram for contrast command
PPP Updates
Format Error Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.