[W17-3]In-Credit-ble #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchj1995
pushed a commit
to cchj1995/addressbook-level4
that referenced
this pull request
Mar 11, 2019
Minor Update for UserGuide
adamwth
approved these changes
Mar 12, 2019
There was a problem hiding this comment.
Feedback for v1.1
Well done! On the ball for most v1.1 milestone objectives. I have also left some recommended changes for your UG and DG in their respective PDFs, which will be given to you shortly.
Github repository description
- Description updated
- Link to Github pages updated
README
- Project name updated
- UI Mockup updated
- Description updated
- Badges updated (Travis, Netlify)
- AB4 ackhowledgement
About Us
- Photos updated
- Roles updated
UG and DG
Comments are in their respective PDFs.
Minor correction based on Mock PE + Implemented test for SetCommand
PPP - final version
Minor edits to documentation
Cleaned up some files
Edited User Guide
Updated PPP
Updates to documents
Final Updates to Docs
Resolved month bug
update UG, DG
Edited PPP
Updated PPP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@geezlouisee @eugeneyl @Jackimaru96 @kjiaxuan