[W16-4] Recruiting Platform #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lestertj
reviewed
Mar 10, 2019
There was a problem hiding this comment.
GitHub project page
- Please update the link at the top of your GitHub page
Readme Page
- The site doesn't seem to be linked correctly; can you make your repo name uppercase? Comments from this point forth will be based on your .adoc files.
- Try to show more in your mockup; what kind of interface can I expect to see?
- Point your Travis CI build badge to your repo, not S-EDU addressbook
About Us
- Fill in the components each member will be developing
You will be receiving your UG and DG comments separately.
DMGREENHOUSE
pushed a commit
to DMGREENHOUSE/addressbook-level4
that referenced
this pull request
Mar 19, 2019
UserGuide and Portfolio Updates
[v1.4] Unit tests for FilterCommand and FilterCommandParser are updated
…sements, positions and skills
… PersonBuilder for testing purposes
local merge
Endorse Command updates
Checkstyle issues
…hing methods are used and all temporarily kept here for the purpose of the upcoming deadline
… tags were changed to skills and there is now room for seperate skill, position and endorsement tags. These are all utilised by the PersonBuilder.
…ition fields. FilterCommand tests are updated accordingly
…positions, endorsements, skill number, position number, endorsement number)
local changes
Model Diagrams
Developer and User Guide changes
Updates are taken
Developer Guide Fix
local updates
Final PR for v1.4, documentation updates
Updates are taken
Tag in a wrong place problem fix in Developer Guide
Final v1.4 changes
Fixes to the PPP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@charnixon @barisbatuhan @DMGREENHOUSE