Upgrade dev dependencies #1533
Merged
Upgrade dev dependencies #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
li-kai
commented
Feb 9, 2019
li-kai
commented
- Upgrades babel & jest
- Improve jest performance
- Improve babel and js performance
|
Deploy preview for nusmods ready! Built with commit 853980b |
ZhangYiJiang
reviewed
Feb 9, 2019
|
Code coverage somehow increased 16%. Either you broke the code coverage path config or you fixed it. Can you check which one it is? :P |
|
CI seem to be slightly faster, which is nice, and bundle size is smaller by 4kb gzipped, which is a small win |
taneliang
reviewed
Feb 9, 2019
|
@ZhangYiJiang It was broken because it wasn't covering all the files without a test file beside. However, test coverage still went up, because we ignore test-utils instead of test_utils now 💯 |
li-kai
force-pushed
the
kli/babel
branch
2 times, most recently
from
1364a3b to
1317461
Compare
ZhangYiJiang
approved these changes
Feb 9, 2019
| ], | ||
| snapshotSerializers: ['<rootDir>/node_modules/enzyme-to-json/serializer'], | ||
| collectCoverageFrom: ['**/*.{js,jsx}'], | ||
| coveragePathIgnorePatterns: ['/node_modules/', '<rootDir>/src/js/(?:test-utils|e2e)'], |
There was a problem hiding this comment.
I think the ?: is unnecessary. It makes it a non-capturing group, which captures intent better, but it makes it a bit harder to read. I can go either way 🤷♂️
dvrylc
pushed a commit
to dvrylc/nusmods
that referenced
this pull request
Feb 16, 2019
* Upgrade babel config * Update jest config * Improve test performance * Align babel config with create-react-app * Fix various config flows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.