Migrate www to typescript #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for nusmods ready! Built with commit d23a701 |
yangshun
approved these changes
Feb 12, 2019
taneliang
reviewed
Feb 12, 2019
|
|
||
| When adding a JavaScript package, Flow requires a library definition, or libdef. To try to install one from the [community repository][flow-typed], use the `flow-typed` command. If a community libdef is not available, the same command can also be used to create a stub libdef which you can use immediately in a pinch, or edit to fill in the correct definitions. | ||
| When adding a JavaScript package, Flow requires a library definition, or libdef. To try to install one from the [community repository][definitely-typed], install `@types/<package name>`. Make sure the installed libdef's version matches that of the package. |
| @@ -26,13 +26,16 @@ describe('#createLocalStorageShim', () => { | |||
|
|
|||
| test('should not throw when setting null/undefined', () => { | |||
| const shim = createLocalStorageShim(); | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
The storage shim doesn't conform to the Storage interface defined by TS. We should fix that by the way - it should not be doing JSON.stringify in setItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables typescript compilation. Right now,
tsc --noEmitgives 0 errors!There are ~980 warnings in strict mode and about ~600 without. I'd like help in fixing these errors 😂