Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPE page introduction content #3183

Merged
merged 10 commits into from
Jan 21, 2021

Conversation

alissayarmantho
Copy link
Contributor

Context

#3035

Add MPE page introduction content.

Implementation

Added content to website/src/views/mpe/MpeContainer.tsx and its corresponding styling.

Other Information

@vercel
Copy link

vercel bot commented Jan 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nusmods-website – ./website

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-website/bg9gew8mb
✅ Preview: https://nusmods-website-git-fork-alissayarmantho-master.nusmodifications.vercel.app

nusmods-export – ./export

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-export/mqwoxabzs
✅ Preview: https://nusmods-export-git-fork-alissayarmantho-master.nusmodifications.vercel.app

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #3183 (3c70f89) into master (1cc25c8) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3183   +/-   ##
=======================================
  Coverage   55.40%   55.40%           
=======================================
  Files         254      254           
  Lines        5315     5315           
  Branches     1226     1226           
=======================================
  Hits         2945     2945           
  Misses       2370     2370           
Impacted Files Coverage Δ
website/src/views/mpe/MpeContainer.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc25c8...3c70f89. Read the comment docs.

@nusmods-deploy-bot
Copy link

nusmods-deploy-bot bot commented Jan 20, 2021

.subtitle{
padding-top: 1rem;
font-weight: bold;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm the formatting is a bit off. Could you run Prettier on this? You could set up your editor to automatically format on save for convenience

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright fixed.

Copy link
Member

@taneliang taneliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks :D

@taneliang taneliang merged commit 1c8d0d2 into nusmodifications:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants