Mpeform (working draft) #3238
Merged
Mpeform (working draft) #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented MPE preference reordering
- getSSOLink function gets NUS SSO login page URL - getMPEPreference gets students existing module preference if any - updateMPEPreference updates students module preference
…al functions to update and delete preferences (Midway Progress)
Mpe api calls by Nicolas (KOOTSTHEHOOTS)
Handle NUS Auth token state within MPE API abstraction
Complete UI integration with APIs
Implement updating of module type
Fix linting issues
- Center content - Simplify elements with Bootstrap styles
- Add opaque background to delete button - Fix Rank header size to match card rank size - Fix card rank size so it is constant between cards
taneliang
approved these changes
Feb 27, 2021
There was a problem hiding this comment.
Thanks for all the work @alissayarmantho @chuabingquan @KOOTSTHEHOOTS @ZhangYiJiang @li-kai @chrisgzf! 🎉
Thanks @williamhutech for helping to layout the foundations for the design! 🍾 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#3035
Add the MPE page UI (draft)
Implementation
Implementing the UI design and integrating the front-end to the back-end
Other Information