Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MPE #3249

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Enable MPE #3249

merged 1 commit into from
Feb 27, 2021

Conversation

taneliang
Copy link
Member

Context

#3035. Flipping this flag to enable MPE on latest.nusmods.com. This can be pushed to production on 1 March.

@vercel
Copy link

vercel bot commented Feb 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nusmods-website – ./website

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-website/73pbt3Q3Q5tf8HixhNb9TrEH4SDW
✅ Preview: https://nusmods-website-git-eliang-mpe-gate-enable-nusmodifications.vercel.app

nusmods-export – ./export

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-export/6zZnyavTCeBri4M4iazYjCtau4x7
✅ Preview: https://nusmods-export-git-eliang-mpe-gate-enable-nusmodifications.vercel.app

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #3249 (bc1b6f9) into master (2377c03) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3249      +/-   ##
==========================================
+ Coverage   52.75%   52.82%   +0.06%     
==========================================
  Files         270      270              
  Lines        5715     5715              
  Branches     1318     1318              
==========================================
+ Hits         3015     3019       +4     
+ Misses       2700     2696       -4     
Impacted Files Coverage Δ
website/src/featureFlags.ts 100.00% <100.00%> (ø)
website/src/views/layout/Navtabs.tsx 100.00% <0.00%> (+10.00%) ⬆️
...rc/views/components/notfications/Announcements.tsx 78.57% <0.00%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2377c03...bc1b6f9. Read the comment docs.

@nusmods-deploy-bot
Copy link

@taneliang taneliang closed this Feb 27, 2021
@taneliang taneliang reopened this Feb 27, 2021
@taneliang taneliang merged commit e9e01bd into master Feb 27, 2021
@taneliang taneliang deleted the eliang/mpe-gate-enable branch February 27, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant