Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MPE #3268

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Disable MPE #3268

merged 1 commit into from
Mar 14, 2021

Conversation

taneliang
Copy link
Member

Context

#3035

To be deployed to prod midnight 15 March SGT

@taneliang taneliang requested a review from li-kai March 14, 2021 12:30
@vercel
Copy link

vercel bot commented Mar 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nusmods-website – ./website

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-website/CtFE2XEUFweEKeN24CVTDnS5M6ci
✅ Preview: https://nusmods-website-git-eliang-disable-mpe-nusmodifications.vercel.app

nusmods-export – ./export

🔍 Inspect: https://vercel.com/nusmodifications/nusmods-export/9j2uWfXAizZmYEikdMiw7rp2CMbs
✅ Preview: https://nusmods-export-git-eliang-disable-mpe-nusmodifications.vercel.app

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #3268 (1be4bb6) into master (83fcdf6) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3268      +/-   ##
==========================================
- Coverage   52.80%   52.73%   -0.07%     
==========================================
  Files         270      270              
  Lines        5717     5717              
  Branches     1320     1320              
==========================================
- Hits         3019     3015       -4     
- Misses       2698     2702       +4     
Impacted Files Coverage Δ
website/src/featureFlags.ts 100.00% <100.00%> (ø)
...rc/views/components/notfications/Announcements.tsx 57.14% <0.00%> (-21.43%) ⬇️
website/src/views/layout/Navtabs.tsx 90.00% <0.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83fcdf6...1be4bb6. Read the comment docs.

@nusmods-deploy-bot
Copy link

@taneliang
Copy link
Member Author

Verified MPE is closed and the announcement banner is no longer shown. Merging so that @li-kai can deploy at midnight (thanks! :D)

image

image

@taneliang taneliang merged commit 3d577c1 into master Mar 14, 2021
@taneliang taneliang deleted the eliang/disable-mpe branch March 14, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant