-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generate config with only globalImageRegistryMirror set #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
dkoshkin
force-pushed
the
dkoshkin/fix-only-globalImageRegistryMirror
branch
2 times, most recently
from
February 15, 2024 04:19
abb1e9c
to
54085f5
Compare
dkoshkin
force-pushed
the
dkoshkin/fix-only-globalImageRegistryMirror
branch
from
February 15, 2024 06:22
54085f5
to
f59c0f0
Compare
dkoshkin
changed the title
fix: generate config with only globalImageRegistryMirror set"
fix: generate config with only globalImageRegistryMirror set
Feb 15, 2024
jimmidyson
reviewed
Feb 15, 2024
pkg/handlers/generic/mutation/imageregistries/credentials/inject_test.go
Show resolved
Hide resolved
pkg/handlers/generic/mutation/imageregistries/credentials/inject_test.go
Show resolved
Hide resolved
pkg/handlers/generic/mutation/imageregistries/credentials/inject.go
Outdated
Show resolved
Hide resolved
jimmidyson
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the comments! Now I understand! 😅
pkg/handlers/generic/mutation/imageregistries/credentials/credential_provider_config_files.go
Outdated
Show resolved
Hide resolved
Merged
dkoshkin
pushed a commit
that referenced
this pull request
Feb 15, 2024
🤖 I have created a release *beep* *boop* --- ## 0.4.2 (2024-02-15) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Fixes 🔧 * fix: remove word konvoy/ and use cre/ by @dkoshkin in #365 * fix: v2/ in Containerd mirror path by @dkoshkin in #363 * fix: set config_path in Containerd config by @dkoshkin in #364 * fix: generate config with only globalImageRegistryMirror set by @dkoshkin in #362 ### Other Changes * refactor: Fix formatting issue by @jimmidyson in #368 * build: Include CAPX APis by @jimmidyson in #367 * build: Upgrade golangci-lint to 1.56.1 by @jimmidyson in #369 * docs: Update examples to be clusterctl templates by @jimmidyson in #361 **Full Changelog**: v0.4.1...v0.4.2 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dkoshkin
added a commit
that referenced
this pull request
Feb 15, 2024
A change to an auotgenerated file that is [breaking the release](https://github.com/d2iq-labs/capi-runtime-extensions/actions/runs/7921983815) snuck in here #362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #359
I noticed that when the only setting
globalImageRegistryMirror
withoutimageRegistries
that the credential provider configs were not being generated.Tested locally and verified in the Docker container :