fix: Properly set additionalTrustBundle for Nutanix CCM #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
requested review from
dlipovetsky,
dkoshkin,
faiq and
thunderboltsid
jimmidyson
force-pushed
the
jimmi/pc-trustbundle
branch
from
f3713ea to
ca392e5
Compare
faiq
reviewed
Aug 21, 2024
...-api-runtime-extensions-nutanix/templates/ccm/nutanix/manifests/helm-addon-installation.yaml
Show resolved
Hide resolved
faiq
reviewed
Aug 21, 2024
The helm values template contained an error meaning that the additionalTrustBundle setting would have been templated as part of the Helm install, rather than the CAAPH addon deployment, meaning that specifying an additional trust bundle would not work for Nutanix CCM deployments. This commit fixes that and adds tests that use the same template as the CAAPH addon would do from the Helm chart to ensure that the template is now correct.
jimmidyson
force-pushed
the
jimmi/pc-trustbundle
branch
from
ca392e5 to
d9519d7
Compare
faiq
approved these changes
Aug 21, 2024
mhrabovcin
approved these changes
Aug 21, 2024
Merged
jimmidyson
added a commit
that referenced
this pull request
Aug 21, 2024
🤖 I have created a release *beep* *boop* --- ## 0.14.4 (2024-08-21) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Fixes 🔧 * fix: Properly set additionalTrustBundle for Nutanix CCM by @jimmidyson in #874 **Full Changelog**: v0.14.3...v0.14.4 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helm values template contained an error which resulted in the
additionalTrustBundle setting being templated as part of the
Helm install, rather than the CAAPH addon deployment, meaning that
specifying an additional trust bundle would not work for Nutanix CCM
deployments.
This commit fixes that and adds tests that use the same template as the
CAAPH addon would do from the Helm chart to ensure that the template is
now correct.