fix: Remove deprecated toleration for node-role.kubernetes.io/master #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error occurred while trying to automatically change base from
jimmi/k8s-1.30-tests
to
main
September 2, 2024 11:12
|
This PR/issue depends on:
|
jimmidyson
force-pushed
the
jimmi/cleanup-deprecated-toleration
branch
from
0d2ea88 to
0581ea4
Compare
This was removed in Kubernetes v1.24 so is no longer needed and actually throws an error now if it is kept when applying manifests. Removal note in https://kubernetes.io/blog/2022/04/07/upcoming-changes-in-kubernetes-1-24/\#api-removals-deprecations-and-other-changes-for-kubernetes-1-24.
jimmidyson
force-pushed
the
jimmi/cleanup-deprecated-toleration
branch
from
0581ea4 to
decf3d1
Compare
dlipovetsky
approved these changes
Sep 3, 2024
mhrabovcin
approved these changes
Sep 4, 2024
Merged
jimmidyson
added a commit
that referenced
this pull request
Sep 7, 2024
This simplifies the Helm templating directives by not requiring
inception-style escaping of templating braces, e.g. `{{ "{{" }}``
which are very hard to read and can introduce bugs.
This PR also removes the duplicate helm values files currently being
used
to generate the CRS configmaps, and instead references the helm values
that are in the charts directory, which ends up with a reduction in LOC
in
the project to maintain.
I feel this is a simpler way to achieve the same goals as #819 but
without
duplicating files and keeping all chart source files in the charts
directory.
Blocked by #895.
dlipovetsky
pushed a commit
that referenced
this pull request
Sep 25, 2024
🤖 I have created a release *beep* *boop* --- ## 0.16.0 (2024-09-25) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Build with go 1.23 by @jimmidyson in #889 * feat: Enable Hubble Relay in Cilium deployment via CAAPH by @dlipovetsky in #899 * feat: Extract CAAPH values templates to files by @jimmidyson in #896 * feat: Build with go 1.23.1 by @jimmidyson in #913 * feat: Support node taints per nodepool and control plane by @jimmidyson in #909 ### Fixes 🔧 * fix: Remove deprecated toleration for node-role.kubernetes.io/master by @jimmidyson in #895 * fix: Do not use digests for Cilium images by @jimmidyson in #901 ### Other Changes * test: Bump Kubernetes versions for tests by @jimmidyson in #893 * ci: images tool by @faiq in #822 * build: Include Calico images in image list by @jimmidyson in #903 * build: Use upstream packages again from upstream by @jimmidyson in #908 * ci(main): enable creating release-please PR from release branches by @supershal in #912 * docs: Enable dark mode, add Nutanix color, and header links by @jimmidyson in #915 **Full Changelog**: v0.15.0...v0.16.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed in Kubernetes v1.24 so is no longer needed and actually
throws a warning now if it is kept when applying manifests:
Removal note in https://kubernetes.io/blog/2022/04/07/upcoming-changes-in-kubernetes-1-24/#api-removals-deprecations-and-other-changes-for-kubernetes-1-24.
Blocked by #893.