fix: Shorten readiness probe period to try to prevent races #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default readiness probe period is 10s so this should reduce timeouts caused by overzealous probes.
jimmidyson
requested review from
dlipovetsky,
dkoshkin,
thunderboltsid and
supershal
thunderboltsid
approved these changes
Oct 1, 2024
dkoshkin
approved these changes
Oct 1, 2024
jimmidyson
added a commit
that referenced
this pull request
Oct 1, 2024
Default readiness probe period is 10s so this should reduce timeouts caused by overzealous probes. This will need to backported to 0.14 release branch.
|
:( This is the wrong timeout on the helm registry |
What do you mean? |
|
I pushed a different implementation that I prefer to #934 that introduces a startup probe to the CAREN pod instead of changing the readiness probe config so that it doesn't cause the kubelet to run readiness checks more often than necessary after a successful startup. |
Merged
jimmidyson
pushed a commit
that referenced
this pull request
Oct 15, 2024
🤖 I have created a release *beep* *boop* --- ## 0.18.0 (2024-10-15) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Add feature-gates plumbing by @jimmidyson in #919 * feat(api): Add kubernetes version to coredns version mapping by @thunderboltsid in #939 ### Fixes 🔧 * fix: Shorten readiness probe period to try to prevent races by @jimmidyson in #930 * fix: Rename webhook container to manager by @jimmidyson in #932 * fix: list correct registry.k8s.io/sig-storage/csi-snapshotter image by @dkoshkin in #943 * fix: include kube-vip image in generated caren-images.txt by @dkoshkin in #940 ### Other Changes * test(e2e): Add v1.30.5 test for Nutanix by @thunderboltsid in #931 * build: Enable building binary only on macos by @jimmidyson in #918 * build(deps): Update clusterctl binary to v1.8.3 by @thunderboltsid in #929 **Full Changelog**: v0.17.0...v0.18.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default readiness probe period is 10s so this should reduce timeouts
caused by overzealous probes.
This will need to backported to 0.14 release branch.