Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update mindthegap to fix cert rotation #971

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

dlipovetsky
Copy link
Contributor

What problem does this PR solve?:
Previously, mindthegap required a restart rollout after its certificate was rotated. It will now use updated certificates without restarting.

Also see https://github.com/mesosphere/mindthegap/releases/tag/v1.17.0

Which issue(s) this PR fixes:
Fixes https://jira.nutanix.com/browse/NCN-104087

How Has This Been Tested?:

Special notes for your reviewer:

@github-actions github-actions bot added the fix label Nov 12, 2024
@dlipovetsky
Copy link
Contributor Author

dlipovetsky commented Nov 12, 2024

lint-test-helm failed:

Run devbox run --config=. -- echo "Packages installed!"
Info: Ensuring packages are installed.
Error: error running script "echo" in Devbox: execute template flake.nix.tmpl: template: flake.nix.tmpl:52:33: executing "flake.nix.tmpl" at <$pkg.InputAddressedPathForOutput>: error calling InputAddressedPathForOutput: Package "kubectl@latest" cannot be fetched from binary cache store

Passed on second run.

@jimmidyson jimmidyson enabled auto-merge (squash) November 12, 2024 18:30
@jimmidyson jimmidyson merged commit 0f8bd4a into main Nov 12, 2024
24 checks passed
@jimmidyson jimmidyson deleted the dlipovetsky/mindthegap-v1.17.0 branch November 12, 2024 18:33
jimmidyson added a commit that referenced this pull request Nov 13, 2024
🤖 I have created a release *beep* *boop*
---


## 0.23.0 (2024-11-13)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Build with go 1.23.3 and upgrade all tools by @jimmidyson in
#967
### Fixes 🔧
* fix: Update mindthegap to fix cert rotation by @dlipovetsky in
#971
* fix: image registries with no credentials but with a CA by @dkoshkin
in
#927
### Other Changes
* build: set helmRepository tag in list-images target by @dkoshkin in
#968
* build: rename caren-helm-reg to better match role by @dkoshkin in
#969


**Full Changelog**:
v0.22.0...v0.23.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants