Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Timeout for WaitForIP #82

Closed
wolfganghuse opened this issue Jan 5, 2023 · 5 comments · Fixed by #84
Closed

Configurable Timeout for WaitForIP #82

wolfganghuse opened this issue Jan 5, 2023 · 5 comments · Fixed by #84
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@wolfganghuse
Copy link
Contributor

/kind bug

Windows Machine with DHCP needs more than the fixed 5min Timeout to report IP to PrismCentral.
Create an configuration option for timeout

@wolfganghuse wolfganghuse added bug Something isn't working good first issue Good for newcomers labels Jan 5, 2023
@DiscoRiver
Copy link

I'll take a poke at this, shouldn't take long. Just so I'm clear, are you referring to this timeout, which seems to be 5 seconds, not 5 minutes?

https://github.com/nutanix-cloud-native/packer-plugin-nutanix/blob/main/builder/nutanix/driver.go#L465

I couldn't find any other references that might apply to this, but feel free to redirect if I've missed something.

@wolfganghuse
Copy link
Contributor Author

wolfganghuse commented Jan 5, 2023

There is a loop running 60 times, with 5seconds wait each, which results in 5min fixed.

@DiscoRiver
Copy link

I looked into how we might slot a configurable timeout into this, and I think the best approach would be to add an additional step to wait for the IP, rather than bundling it within the create step. Similar to this;

https://github.com/jetbrains-infra/packer-builder-vsphere/blob/bd2040307ce568a94887e41c644e20fa533f0fc7/common/step_wait_for_ip.go

I don't have enough experience with this code, or the cycles to implement right now, but I think this would be the best approach based on my limited research.

Good luck!

@wolfganghuse
Copy link
Contributor Author

@DiscoRiver Thanks for research, this is indeed a good solution. However, lets raise the fixed timeout now to 15min as a workaround for slow Windows Deployments until we implement the WaitForIP Step.

@tuxtof
Copy link
Contributor

tuxtof commented Jan 9, 2023

@DiscoRiver you can test with v0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
3 participants