Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ip_wait_timeout feature #84

Merged
merged 1 commit into from
Jan 9, 2023
Merged

add ip_wait_timeout feature #84

merged 1 commit into from
Jan 9, 2023

Conversation

tuxtof
Copy link
Contributor

@tuxtof tuxtof commented Jan 8, 2023

What this PR does / why we need it:

implement ip_wait_timeout option: Amount of time to wait for VM's IP , set to 15 min if not defined
update golang depdendencies to fix CVE-2022-41717

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #82
Replace #83

How Has This Been Tested?:

build and test

Release note:

implement `ip_wait_timeout` option

@tuxtof tuxtof added the enhancement New feature or request label Jan 8, 2023
@tuxtof tuxtof requested a review from wolfganghuse January 8, 2023 18:32
@tuxtof tuxtof force-pushed the feat/ip_wait_timeout branch from cc0bd9a to 6116ac8 Compare January 8, 2023 18:39
@tuxtof tuxtof added the dependencies Pull requests that update a dependency file label Jan 8, 2023
@tuxtof tuxtof requested a review from Golgautier January 9, 2023 07:29
Copy link
Contributor

@Golgautier Golgautier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change ok for me (code update & doc).

Tested and ok.

Copy link
Contributor

@wolfganghuse wolfganghuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuxtof tuxtof merged commit 793811c into main Jan 9, 2023
@tuxtof tuxtof deleted the feat/ip_wait_timeout branch January 9, 2023 10:56
@github-actions
Copy link

✅ None of your dependencies violate policy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable Timeout for WaitForIP
3 participants