Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrote Cleanup process #101

Merged
merged 1 commit into from
Feb 14, 2023
Merged

rewrote Cleanup process #101

merged 1 commit into from
Feb 14, 2023

Conversation

tuxtof
Copy link
Contributor

@tuxtof tuxtof commented Feb 14, 2023

What this PR does / why we need it:

  • remove dedicated cleanup Step
  • rewrote cleaning logic using builtin Cleanup approach

Release note:

- cleanup logic improvement

@tuxtof tuxtof added the enhancement New feature or request label Feb 14, 2023
@tuxtof tuxtof requested a review from wolfganghuse February 14, 2023 13:17
wolfganghuse
wolfganghuse previously approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@wolfganghuse wolfganghuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • build
  • abort running task
  • sucessfully run build task and cleaned up

@github-actions
Copy link

✅ None of your dependencies violate policy!

@tuxtof tuxtof merged commit 54e2cdc into main Feb 14, 2023
@tuxtof tuxtof deleted the fix/cleanup-step branch February 14, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfganghuse wolfganghuse wolfganghuse left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuxtof @wolfganghuse