Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix multi disks vm image creation #118

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix multi disks vm image creation #118

merged 1 commit into from
Mar 21, 2023

Conversation

tuxtof
Copy link
Contributor

@tuxtof tuxtof commented Mar 20, 2023 •
edited
Loading

What this PR does / why we need it:

If a VM is created with multiple disks , save all the disks as images with the following name

image_name
image_name-disk2
image_name-disk3
....

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #117

Release note:

- support multi disks VM image

@tuxtof tuxtof added the bug Something isn't working label Mar 20, 2023
@tuxtof tuxtof requested a review from wolfganghuse March 20, 2023 07:13
@tuxtof tuxtof mentioned this pull request Mar 20, 2023
Closed
wolfganghuse
wolfganghuse reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@wolfganghuse wolfganghuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add a second Disk to e2e test?

@tuxtof tuxtof force-pushed the fix/multi-disk branch 3 times, most recently from 7ef8345 to 8192b37 Compare March 21, 2023 12:03
@github-actions
Copy link

✅ None of your dependencies violate policy!

wolfganghuse
wolfganghuse approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@wolfganghuse wolfganghuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuxtof tuxtof merged commit df8ce13 into main Mar 21, 2023
@tuxtof tuxtof deleted the fix/multi-disk branch March 21, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfganghuse wolfganghuse wolfganghuse approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for VM's with multiple disks?
2 participants
@tuxtof @wolfganghuse