Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UEFI boot type #32

Merged
merged 1 commit into from
Jul 29, 2022
Merged

add UEFI boot type #32

merged 1 commit into from
Jul 29, 2022

Conversation

tuxtof
Copy link
Contributor

@tuxtof tuxtof commented Jul 29, 2022

What this PR does / why we need it:

Allow changing bootype of builder VM to UEFI

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #28

How Has This Been Tested?:

source "nutanix" "linux" {
......
  boot_type        = "uefi"
}

Release note:

allow UEFI Boot Type configuration

@tuxtof tuxtof added the documentation Improvements or additions to documentation label Jul 29, 2022
@tuxtof tuxtof added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Jul 29, 2022
@github-actions
Copy link

✅ None of your dependencies violate policy!

@tuxtof tuxtof merged commit 07ece68 into main Jul 29, 2022
@tuxtof tuxtof deleted the feat/uefi-support branch July 29, 2022 15:39
@ktinthecloud
Copy link

ktinthecloud commented Jul 30, 2022

@tuxtof can you add the boot_type = "uefi" to the example section of the repo? I'm having a hard time trying to figure out how to use it. Thanks!

Error: Unsupported argument

on source.nutanix.pkr.hcl line 98:
(source code not available)

An argument named "boot_type" is not expected here.

==> Wait completed after 2 microseconds

==> Builds finished but no artifacts were created.

@ktinthecloud
Copy link

This is working now. Just had to wait for the v0.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packer image created as "Legacy BIOS" instead of "UEFI"
3 participants