Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation #57

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Documentation #57

merged 2 commits into from
Nov 24, 2022

Conversation

Golgautier
Copy link
Contributor

Add documentation file to this repo

Release note:

NONE

@Golgautier Golgautier force-pushed the Documentation branch 2 times, most recently from cbc6a3b to 577149e Compare September 23, 2022 10:37
tuxtof
tuxtof reviewed Sep 23, 2022
View reviewed changes
docs/datasources.mdx Outdated Show resolved Hide resolved
@tuxtof tuxtof marked this pull request as draft September 23, 2022 11:51
wolfganghuse
wolfganghuse reviewed Sep 24, 2022
View reviewed changes
docs/builders/overview.mdx Outdated Show resolved Hide resolved
docs/builders/plugin.mdx Outdated Show resolved Hide resolved
docs/builders/plugin.mdx Show resolved Hide resolved
docs/builders/plugin.mdx Show resolved Hide resolved
docs/builders/plugin.mdx Outdated Show resolved Hide resolved
docs/builders/plugin.mdx Show resolved Hide resolved
@Golgautier Golgautier force-pushed the Documentation branch 3 times, most recently from c078a45 to 1fdd615 Compare September 26, 2022 07:52
@tuxtof tuxtof added the documentation Improvements or additions to documentation label Sep 27, 2022
@tuxtof tuxtof force-pushed the Documentation branch 2 times, most recently from baf1555 to 964b8a2 Compare November 20, 2022 08:48
@tuxtof tuxtof marked this pull request as ready for review November 20, 2022 08:48
@wolfganghuse
Copy link
Contributor

We need to add latest switches for image override and source uri

@tuxtof
Copy link
Contributor

tuxtof commented Nov 20, 2022

We need to add latest switches for image override and source uri

@Golgautier can you take care of it ?

@Golgautier
Copy link
Contributor Author

Sure.

@Golgautier
Copy link
Contributor Author

We need to add latest switches for image override and source uri

@Golgautier can you take care of it ?

Done :)

tuxtof
tuxtof reviewed Nov 23, 2022
View reviewed changes
docs/builders/plugin.mdx Outdated Show resolved Hide resolved
wolfganghuse
wolfganghuse reviewed Nov 24, 2022
View reviewed changes
Copy link
Contributor

@wolfganghuse wolfganghuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my side only minimum version needs to be fixed..

docs/builders/overview.mdx Outdated Show resolved Hide resolved
@tuxtof tuxtof self-requested a review November 24, 2022 10:55
tuxtof
tuxtof approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@tuxtof tuxtof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuxtof tuxtof merged commit b20189b into nutanix-cloud-native:main Nov 24, 2022
@Golgautier Golgautier deleted the Documentation branch November 24, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfganghuse wolfganghuse wolfganghuse left review comments

@tuxtof tuxtof tuxtof approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Golgautier @wolfganghuse @tuxtof