Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

artefact identification improvement #71

Merged
merged 1 commit into from
Nov 21, 2022
Merged

artefact identification improvement #71

merged 1 commit into from
Nov 21, 2022

Conversation

tuxtof
Copy link
Contributor

@tuxtof tuxtof commented Nov 20, 2022 •
edited
Loading

What this PR does / why we need it:

  • add description to identify temporary VM
  • add downloaded image description
  • add customisable image description (field image_description)
  • add Image Name in successful message

How Has This Been Tested?:

packer build

Release note:

- add description to identify temporary VM
- add downloaded image description
- add customisable image description (field `image_description`)
- add Image Name in successful message

@tuxtof tuxtof added the enhancement New feature or request label Nov 20, 2022
@tuxtof tuxtof requested a review from wolfganghuse November 20, 2022 11:19
wolfganghuse
wolfganghuse previously approved these changes Nov 20, 2022
View reviewed changes
Copy link
Contributor

@wolfganghuse wolfganghuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run through e2e-test

@tuxtof tuxtof force-pushed the feat/artefact-identification branch from 8954bba to 38d38ac Compare November 20, 2022 15:35
@tuxtof
artefact identification improvement
0987e64 
- add vm description
- add downloaded image description
- add customizable image description
- add Image Name in sucesfull message
@tuxtof tuxtof force-pushed the feat/artefact-identification branch from 38d38ac to 0987e64 Compare November 20, 2022 15:35
@tuxtof tuxtof requested a review from wolfganghuse November 20, 2022 15:41
wolfganghuse
wolfganghuse approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@wolfganghuse wolfganghuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run through short centos e2e...

@tuxtof tuxtof merged commit 390ad16 into main Nov 21, 2022
@tuxtof tuxtof deleted the feat/artefact-identification branch November 21, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfganghuse wolfganghuse wolfganghuse approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuxtof @wolfganghuse