Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font size and fix mouse size plus stroke (line) #49

Closed
mac4kent opened this issue Mar 7, 2021 · 21 comments
Closed

Fix font size and fix mouse size plus stroke (line) #49

mac4kent opened this issue Mar 7, 2021 · 21 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mac4kent
Copy link

mac4kent commented Mar 7, 2021

Description about the feature
The description about the feature. It is good to clear who will benefit with this feature.
I can't read too thin and too small font

Are you willing to contribute about this feature. (Yes/No)
no

Screenshots [Optional]
See below and left side you can see too small font and can't read too thin stroke (line)
Need to make very thickness stroke and should be 300pt font not limit 24pt
Mouse should be 300 not 144

image

Additional comments [Optional]
For Mac only
image

More space of Display within 5K Retina Display.
image

@mac4kent mac4kent added the enhancement New feature or request label Mar 7, 2021
@mac4kent
Copy link
Author

mac4kent commented Mar 7, 2021

I just change code from 24 to 300 font size and mouse too. I am try find out stroke to be thickness in the code.
image

@mac4kent
Copy link
Author

mac4kent commented Mar 7, 2021

Need add feature for Mac only please
Shift, Control, Option, and Command too
Not for Windows.

@nutti
Copy link
Owner

nutti commented Mar 7, 2021

@mac4kent

Need add feature for Mac only please
Not for Windows.

Why only macOS?
I don't want to change the add-on's behavior among the platform.

@nutti
Copy link
Owner

nutti commented Mar 7, 2021

@mac4kent

BTW, I did not reject your request.
I want to know why you want to add this feature only macOS.
I think this improvement will also be effective for Windows.
What do you think?

@mac4kent
Copy link
Author

mac4kent commented Mar 7, 2021

I mean keyboard I show you 3 different picture that match for Mac.
Blender keyboard screencast keys
IMG_0307
IMG_0308

@nutti
Copy link
Owner

nutti commented Mar 7, 2021

@mac4kent

Shift, Control, Option, and Command too

I think above request should be on the other issue. Could you make another issue about this request?
This feature request is not same to this issue.

And also, I want to ask you why the removal of these limitation is needed only for macOS you described in the first comment.
Removing the limitation of font size and mouse size is useful for Windows.

@mac4kent
Copy link
Author

mac4kent commented Mar 7, 2021

That is VERY ENOUGH to ask me "WHY WHY WHY" too much.
Gaia Clary know already and think about deaf/blind people must remove limitation. change to unlimit and mouse too thinner need to fix thickness.

@nutti
Copy link
Owner

nutti commented Mar 7, 2021

@mac4kent

Understood. I was wondering there is a intention for limiting the platform.
Thanks for the clarification.

@nutti
Copy link
Owner

nutti commented Mar 7, 2021

The early patch works for me in Windows system, and does not in macOS system.
I found we need to avoid using glLineWidth in macOS system.
Ref: https://developer.blender.org/T57570

We need a time to add this feature to check whether we can realize this feature or not because of the API limitation.

@nutti
Copy link
Owner

nutti commented Mar 7, 2021

Almost done.
Changing stroke width will only support for Blender 2.92 or later in macOS environment which supports 3D_POLYLINE_UNIFORM_COLOR shader.
We think it is enough because Blender itself can handle this issue after Blender 2.92 was released. (c.f. above the discussion on T57570)

@mac4kent
Copy link
Author

mac4kent commented Mar 7, 2021

Oh really thanks. I am use Blender 2.93 Alpha.

@mac4kent
Copy link
Author

mac4kent commented Mar 7, 2021

Good job you found out everything. You saw I report ticket to Blender many list and they fix lot and lot bug.

@nutti
Copy link
Owner

nutti commented Mar 8, 2021

@mac4kent

Is it possible to try the temporary version in your environment?
https://github.com/nutti/Screencast-Keys/archive/issue_49.zip

This version works fine in my macOS environment.

@mac4kent
Copy link
Author

mac4kent commented Mar 8, 2021

Thank you for send me link on .zip and I don't know how to do.
image

@nutti
Copy link
Owner

nutti commented Mar 8, 2021

@mac4kent

Thanks for your cooperation.
The installation process is same as unstable version.
Could you follow the below Manual Install process?

https://github.com/nutti/Screencast-Keys/blob/master/docs/installation.md#manual-install

In your environment, you can start from the process 3.

i.e.

  • copy src/screencast_keys directory to /Users/<username>/Library/Application Support/Blender/<blender_version>/scripts/addons
  • Enable the add-on

@mac4kent
Copy link
Author

mac4kent commented Mar 8, 2021

This link I don't understand but I found on. my Mac.
image
image

Look awesome thank you for feature and look much better.

@mac4kent
Copy link
Author

mac4kent commented Mar 8, 2021

I did take screen shot is a Shift + Control + Command + F3.

@nutti
Copy link
Owner

nutti commented Mar 8, 2021

Thanks @mac4kent .

I will merge the patch to the master branch soon.

@mac4kent
Copy link
Author

mac4kent commented Mar 8, 2021

Sure no problem

@nutti
Copy link
Owner

nutti commented Mar 8, 2021

The patch is now merged to master branch.

@nutti nutti closed this as completed Mar 8, 2021
@mac4kent
Copy link
Author

mac4kent commented Mar 8, 2021

Cooooooooooool good job.

@nutti nutti self-assigned this Mar 8, 2021
@nutti nutti added this to the Version 3.6 milestone Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants