Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new visual options #54

Merged
merged 7 commits into from
Jul 23, 2021
Merged

add new visual options #54

merged 7 commits into from
Jul 23, 2021

Conversation

Kureii
Copy link
Contributor

@Kureii Kureii commented Apr 6, 2021

Add new feature
add option of margin and round coner of background.

@nutti
Copy link
Owner

nutti commented Apr 7, 2021

@Kureii

Thanks for the PR! It looks nice feature to me.
I tried your patch in my environment.
But the render result seems not fine.
Background color and the rectangle size is invalid.

OS: Windows 10
Blender: Both 2.83 and 2.91

github_20210407

Could you check your patch in your environment?

@nutti nutti added the enhancement New feature or request label Apr 7, 2021
@nutti
Copy link
Owner

nutti commented Apr 20, 2021

@Kureii

Is there any update?
If you stuck, I can help you.

@Kureii
Copy link
Contributor Author

Kureii commented Apr 20, 2021

@nutti
Sorry only I don't have time, too much things to school

@Kureii Kureii closed this Apr 20, 2021
@Kureii Kureii reopened this Apr 20, 2021
@nutti
Copy link
Owner

nutti commented Apr 20, 2021

@Kureii

No, problem.
If you need a help, feel free to tell me.

@nutti
Copy link
Owner

nutti commented Jun 19, 2021

@Kureii

Is there any update about this PR?
If you are not enough time to tackle this, I will try to do additional work.

@Kureii
Copy link
Contributor Author

Kureii commented Jun 20, 2021

@nutti
today I finishing my last projecto to the school and now I'll have a time for this

@Kureii
Copy link
Contributor Author

Kureii commented Jul 12, 2021

I don't know, where I do mistake, I replace draw_box to draw_roundet_box, but it isint work in draw area mode...

@nutti
Copy link
Owner

nutti commented Jul 13, 2021

@Kureii

Please double-check your patch while Background option is on.
Your patch breaks the background and cursor color.

I will show you the expected behavior

github_20210713

@nutti
Copy link
Owner

nutti commented Jul 15, 2021

@Kureii

BTW, does this patch work on your environment?
I think that some changes break the layout.

If you provide me the specification of margin and background_round option, I will fix them.

@nutti
Copy link
Owner

nutti commented Jul 15, 2021

I fixed your patch on my environment.

github_20210715

There are still UI break changes, so we need to fix other places too.

@nutti
Copy link
Owner

nutti commented Jul 17, 2021

@Kureii

Is it possible to enable Allow edits by maintainers of this PR?
If this option is enabled, I can commit my patch to your branch.

My patch also can be seen from kureii-patch branch.

@nutti nutti added this to the Version 3.6 milestone Jul 18, 2021
@Kureii
Copy link
Contributor Author

Kureii commented Jul 20, 2021

I had same problem and I didn't know how to repair it

@nutti
Copy link
Owner

nutti commented Jul 20, 2021

@Kureii

I have already fixed your issue. So I want to merge my codes to your repository.
Could you enable Allow edits from maintainers checkbox from right side of this PR?

Please also see this documents.
https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@Kureii
Copy link
Contributor Author

Kureii commented Jul 20, 2021

It's enable

@nutti
Copy link
Owner

nutti commented Jul 20, 2021

@Kureii

Sorry for my failed operation.

I tried to fix the issue.
At first, could you merge this PR?
Kureii#1

@nutti nutti reopened this Jul 22, 2021
@nutti
Copy link
Owner

nutti commented Jul 22, 2021

@Kureii

Thanks for merging my PR. Now I can reopen this PR.
I think the current version in master branch on your repository works fine (above bugs are fixed).
Could you check this one on your environment?

@Kureii
Copy link
Contributor Author

Kureii commented Jul 22, 2021

It's work good, I don't have any problem

@nutti
Copy link
Owner

nutti commented Jul 22, 2021

@Kureii

Thanks.
I will merge this PR after some small fix.

Copy link
Owner

@nutti nutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for trying to do this work! @Kureii

@Kureii
Copy link
Contributor Author

Kureii commented Jul 23, 2021

I need more practise, this was my first try with coding blender add-on.

@nutti nutti merged commit 73c347b into nutti:master Jul 23, 2021
@nutti
Copy link
Owner

nutti commented Jul 23, 2021

@Kureii

Thanks for nice suggestions and great works to this project.
If you consider to contribute to this project more, feel free to open new PR.
This project is contribution welcomed.

@Kureii
Copy link
Contributor Author

Kureii commented Jul 23, 2021

thank you for your willingness and patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants