ELEMENTS-1153: simplify test linting

nuxeo · Apr 6, 2020 · 49c3d61 · 49c3d61
1 parent 0a8d728
commit 49c3d61
Show file tree

Hide file tree

Showing 37 changed files with 16 additions and 94 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -60,5 +60,19 @@ module.exports = {
         Polymer: 'readonly',
       },
     },
+    {
+      files: ['**/*.test.js'],
+      env: {
+        mocha: true,
+      },
+      rules: {
+        'no-unused-expressions': 'off',
+      },
+      globals: {
+        assert: 'readable',
+        expect: 'readable',
+        sinon: 'readable',
+      },
+    },
   ],
 };
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1,3 @@
+analysis.json
 node_modules
 coverage
diff --git a/core/.gitignore b/core/.gitignore
diff --git a/core/test/.eslintrc.json b/core/test/.eslintrc.json
diff --git a/core/test/nuxeo-document.test.js b/core/test/nuxeo-document.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import { waitChanged, fixture, html } from '@nuxeo/testing-helpers';
 import '../nuxeo-document.js';
 
-/* eslint-disable no-unused-expressions */
 suite('nuxeo-document', () => {
   const responseHeaders = {
     json: { 'Content-Type': 'application/json' },

diff --git a/core/test/nuxeo-operation.test.js b/core/test/nuxeo-operation.test.js
@@ -18,7 +18,6 @@ import { fixture, html, waitChanged } from '@nuxeo/testing-helpers';
 import '../nuxeo-operation.js';
 import '../nuxeo-page-provider.js';
 
-/* eslint-disable no-unused-expressions */
 suite('nuxeo-operation', () => {
   const responseHeaders = {
     json: { 'Content-Type': 'application/json' },

diff --git a/core/test/nuxeo-page-provider.test.js b/core/test/nuxeo-page-provider.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import { fixture, html } from '@nuxeo/testing-helpers';
 import '../nuxeo-page-provider.js';
 
-/* eslint-disable no-unused-expressions */
 suite('nuxeo-page-provider', () => {
   const responseHeaders = {
     json: { 'Content-Type': 'application/json' },

diff --git a/core/test/nuxeo-resource.test.js b/core/test/nuxeo-resource.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import { fixture, html } from '@nuxeo/testing-helpers';
 import '../nuxeo-resource.js';
 
-/* eslint-disable no-unused-expressions */
 suite('nuxeo-resource', () => {
   const responseHeaders = {
     json: { 'Content-Type': 'application/json' },

diff --git a/core/test/nuxeo-task-page-provider.test.js b/core/test/nuxeo-task-page-provider.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import '../nuxeo-task-page-provider.js';
 import { fakeServer, fixture, html, waitForEvent } from '@nuxeo/testing-helpers';
 
-/* eslint-disable no-unused-expressions */
 suite('nuxeo-task-page-provider', () => {
   suite('REST Calls', () => {
     let server;

diff --git a/core/test/utils.test.js b/core/test/utils.test.js
@@ -16,7 +16,6 @@
  */
 import { createNestedObject } from '../utils.js';
 
-/* eslint-disable no-unused-expressions */
 suite('utils', () => {
   suite('"createNestedObject" function', () => {
     suite('Parameters Validation', () => {

diff --git a/dataviz/.gitignore b/dataviz/.gitignore
diff --git a/dataviz/test/.eslintrc.json b/dataviz/test/.eslintrc.json
diff --git a/polymer.json b/polymer.json
@@ -1,6 +1,7 @@
 {
   "lint": {
     "rules": ["polymer-3"],
+    "filesToIgnore": ["**/node_modules/**/*.js"],
     "ignoreWarnings": [
       "databinding-calls-must-be-functions",
       "could-not-resolve-reference"

diff --git a/testing-helpers/.gitignore b/testing-helpers/.gitignore
diff --git a/testing-helpers/.npmignore b/testing-helpers/.npmignore
diff --git a/ui/.gitignore b/ui/.gitignore
diff --git a/ui/test/.eslintrc.json b/ui/test/.eslintrc.json
diff --git a/ui/test/nuxeo-actions-menu.test.js b/ui/test/nuxeo-actions-menu.test.js
@@ -25,7 +25,6 @@ import '../widgets/nuxeo-actions-menu.js';
 
 window.html = html; // make it available for building custom elements inline
 
-/* eslint-disable no-unused-expressions */
 suite('nuxeo-actions-menu', () => {
   function makeMenuContent(n = 5) {
     return html`

diff --git a/ui/test/nuxeo-create-group.test.js b/ui/test/nuxeo-create-group.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import { fixture, flush, html, login, tap, waitChanged } from '@nuxeo/testing-helpers';
 import { dom } from '@polymer/polymer/lib/legacy/polymer.dom.js';
 import '../nuxeo-user-group-management/nuxeo-create-group.js';
-/* eslint-disable no-unused-expressions */
 
 suite('nuxeo-create-group', () => {
   let server;

diff --git a/ui/test/nuxeo-date-picker.test.js b/ui/test/nuxeo-date-picker.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import { fixture, html } from '@nuxeo/testing-helpers';
 import moment from '@nuxeo/moment';
 import '../widgets/nuxeo-date-picker.js';
-/* eslint-disable no-unused-expressions */
 
 function getInput(element) {
   return element.root.querySelector('#date');

diff --git a/ui/test/nuxeo-delete-document-button.test.js b/ui/test/nuxeo-delete-document-button.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import { fixture, flush, html, isElementVisible, tap, waitForEvent } from '@nuxeo/testing-helpers';
 import { dom } from '@polymer/polymer/lib/legacy/polymer.dom';
 import '../actions/nuxeo-delete-document-button.js';
-/* eslint-disable no-unused-expressions */
 
 const getActionDiv = (button) => dom(button.root).querySelector('.action');
 

diff --git a/ui/test/nuxeo-document-comment-thread.test.js b/ui/test/nuxeo-document-comment-thread.test.js
@@ -28,7 +28,6 @@ import {
   waitForEvent,
 } from '@nuxeo/testing-helpers';
 
-/* eslint-disable no-unused-expressions */
 suite('nuxeo-document-comment-thread', () => {
   let element;
   let server;

diff --git a/ui/test/nuxeo-document-comment.test.js b/ui/test/nuxeo-document-comment.test.js
@@ -32,7 +32,6 @@ function getCommentContent(element) {
   return element.shadowRoot.querySelector('#content');
 }
 
-/* eslint-disable no-unused-expressions */
 suite('nuxeo-document-comment', () => {
   const longText =
     'Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. ' +

diff --git a/ui/test/nuxeo-document-layout.test.js b/ui/test/nuxeo-document-layout.test.js
@@ -36,7 +36,6 @@ Nuxeo.LayoutBehavior = LayoutBehavior;
 const { url } = import.meta;
 const base = url.substring(0, url.lastIndexOf('/'));
 
-/* eslint-disable no-unused-expressions */
 suite('nuxeo-document-layout', () => {
   let documentLayout;
   const baseUrl = `${base}/layouts/document/`;

diff --git a/ui/test/nuxeo-error.test.js b/ui/test/nuxeo-error.test.js
@@ -16,7 +16,6 @@ limitations under the License.
 */
 import { fixture, flush, html, isElementVisible } from '@nuxeo/testing-helpers';
 import '../nuxeo-error.js';
-/* eslint-disable no-unused-expressions */
 
 suite('<nuxeo-error>', () => {
   const expectNuxeoErrorContent = (nuxeoError, code, description, url, message) => {

diff --git a/ui/test/nuxeo-favorites-toggle-button.test.js b/ui/test/nuxeo-favorites-toggle-button.test.js
@@ -17,8 +17,6 @@ limitations under the License.
 import { fixture, html, login, tap, waitChanged } from '@nuxeo/testing-helpers';
 import '../actions/nuxeo-favorites-toggle-button.js';
 
-/* eslint-disable no-unused-expressions */
-
 suite('nuxeo-favorites-toggle-button', () => {
   let server;
   setup(async () => {

diff --git a/ui/test/nuxeo-filter.test.js b/ui/test/nuxeo-filter.test.js
@@ -20,8 +20,6 @@ import { dom } from '@polymer/polymer/lib/legacy/polymer.dom.js';
 import '../nuxeo-filter.js';
 import '../nuxeo-slots.js';
 
-/* eslint-disable no-unused-expressions */
-
 function stamped(filter, clazz) {
   return dom(filter).querySelectorAll(`${clazz || '*'}:not(nuxeo-filter):not(template)`);
 }

diff --git a/ui/test/nuxeo-html-editor.test.js b/ui/test/nuxeo-html-editor.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import { fixture, isElementVisible, html } from '@nuxeo/testing-helpers';
 import '../widgets/nuxeo-html-editor.js';
 
-/* eslint-disable no-unused-expressions */
 suite('nuxeo-html-editor', () => {
   test('should display the placeholder when empty', async () => {
     const editor = await fixture(

diff --git a/ui/test/nuxeo-image-viewer.test.js b/ui/test/nuxeo-image-viewer.test.js
@@ -20,7 +20,6 @@ import '../viewers/nuxeo-image-viewer.js';
 const { url } = import.meta;
 const base = url.substring(0, url.lastIndexOf('/'));
 
-/* eslint-disable no-unused-expressions */
 suite('nuxeo-image-viewer', () => {
   const viewerLoad = (viewer) => {
     if (viewer._el && viewer._el.ready) {

diff --git a/ui/test/nuxeo-layout.test.js b/ui/test/nuxeo-layout.test.js
@@ -19,7 +19,6 @@ import { fixture, flush, html, isElementVisible, waitChanged, waitForAttrMutatio
 import { Polymer } from '@polymer/polymer/polymer-legacy.js';
 import '../nuxeo-layout.js';
 import '../widgets/nuxeo-input.js';
-/* eslint-disable no-unused-expressions */
 
 // determine base module path (relies on @open-wc/webpack-import-meta-loader)
 const { url } = import.meta;

diff --git a/ui/test/nuxeo-lock-toggle-button.test.js b/ui/test/nuxeo-lock-toggle-button.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import { fixture, flush, html, login, tap, waitForEvent } from '@nuxeo/testing-helpers';
 import { dom } from '@polymer/polymer/lib/legacy/polymer.dom';
 import '../actions/nuxeo-lock-toggle-button.js';
-/* eslint-disable no-unused-expressions */
 
 suite('nuxeo-lock-toggle-button', () => {
   let button;

diff --git a/ui/test/nuxeo-notifications-toggle-button.test.js b/ui/test/nuxeo-notifications-toggle-button.test.js
@@ -17,8 +17,6 @@ limitations under the License.
 import { fixture, html, login, tap, waitChanged } from '@nuxeo/testing-helpers';
 import '../actions/nuxeo-notifications-toggle-button.js';
 
-/* eslint-disable no-unused-expressions */
-
 suite('nuxeo-notifications-toggle-button', () => {
   let server;
   setup(async () => {

diff --git a/ui/test/nuxeo-selectivity.test.js b/ui/test/nuxeo-selectivity.test.js
@@ -26,7 +26,6 @@ import {
 import { dom } from '@polymer/polymer/lib/legacy/polymer.dom.js';
 import '../widgets/nuxeo-selectivity.js';
 
-/* eslint-disable no-unused-expressions */
 suite('nuxeo-selectivity', () => {
   let selectivityWidget;
   const data = ['Berlin', 'Lisbon', 'London', 'Rennes', 'Rome'];

diff --git a/ui/test/nuxeo-slots.test.js b/ui/test/nuxeo-slots.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import { fixture, flush, html, waitForChildListMutation } from '@nuxeo/testing-helpers';
 import * as polymer from '@polymer/polymer';
 import '../nuxeo-slots.js';
-/* eslint-disable no-unused-expressions */
 
 // return all children excluding <nuxeo-slot>
 function _content(slot) {

diff --git a/ui/test/nuxeo-uploader-behavior.test.js b/ui/test/nuxeo-uploader-behavior.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import { fixture, html, login } from '@nuxeo/testing-helpers';
 import '../widgets/nuxeo-file.js';
 import { UploaderBehavior } from '../widgets/nuxeo-uploader-behavior.js';
-/* eslint-disable no-unused-expressions */
 
 suite('Nuxeo.UploaderBehavior', () => {
   let DefaultUploadProvider;

diff --git a/ui/test/nuxeo-video-conversions.test.js b/ui/test/nuxeo-video-conversions.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import { fixture, flush, html, isElementVisible } from '@nuxeo/testing-helpers';
 import '../nuxeo-video/nuxeo-video-conversions.js';
 import videoProperties from './resources/videoProperties';
-/* eslint-disable no-unused-expressions */
 
 suite('nuxeo-video-conversions', () => {
   suite('Displaying element when no parameters provided', () => {

diff --git a/ui/test/nuxeo-video-info.test.js b/ui/test/nuxeo-video-info.test.js
@@ -17,7 +17,6 @@ limitations under the License.
 import { fixture, flush, html, isElementVisible } from '@nuxeo/testing-helpers';
 import '../nuxeo-video/nuxeo-video-info.js';
 import videoProperties from './resources/videoProperties';
-/* eslint-disable no-unused-expressions */
 
 suite('nuxeo-video-info', () => {
   let element;