fix(validator): account for empty Vue scoped style attributes #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an `svg` tag I have many `data-v-...` attributes with an empty value `=""`. These are currently incorrectly replaced by this module's regex.
✅ Deploy Preview for html-validator canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 78.99% 81.65% +2.66%
==========================================
Files 4 4
Lines 219 229 +10
Branches 46 39 -7
==========================================
+ Hits 173 187 +14
+ Misses 46 42 -4 ☔ View full report in Codecov by Sentry. |
danielroe
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an
svgtag I have manydata-v-...attributes with an empty value="". These are currently replaced by this module's regex incorrectly.What's currently detected:
What this PR changes:
Disclaimer: Maybe there shouldn't even be
data-v-...attributes with their value set to="". I see otherdata-v-...attributes with no suffix at all. The existing regex let's me think that the actual bug might be some tooling in my project which incorrectly allowsdata-v-...attributes to have="", but which it shouldn't. Do you have any insight into this @danielroe?