fix: change server proxy preset for @nuxt/icon #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for nuxt-storybook pending review.Visit the deploys page to approve it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #780
📚 Description
Reproduced #780 using latest
@nuxtjs/storybook v8.3.3and can confirm that icons couldn’t be loaded in Storybook because theapi/_nuxt_iconendpoint (from @nuxt/icon) isn’t accessible on port 6006.So I checked all currently proxied routes and noticed that there is a
_iconroute, but it isn’t used by@nuxt/iconor any other official Nuxt module, community module, or icon module listed here. There’s also no Git history explaining why_iconwas added. Therefore, I replaced it with the actualapi/_nuxt_iconendpoint from@nuxt/icon_nuxt_ipx__nuxt_devtools____nuxt_islandapi/_nuxt_icon_iconThis change fixes icon loading with @nuxt/icon in Storybook.
Before:
After: