fix(templates): remove not recommended eslint-plugin-prettier (#797)

Co-authored-by: Xin Du (Clark) <[email protected]>
nuxt · Jun 13, 2021 · 5d8c498 · 5d8c498
1 parent b7d2db9
commit 5d8c498
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 8 deletions.
diff --git a/packages/cna-template/template/_.eslintrc.js b/packages/cna-template/template/_.eslintrc.js
@@ -15,13 +15,13 @@ module.exports = {
     <%_ } else {_%>
     '@nuxtjs',
     <%_ } _%>
-    <%_ if (prettier) { _%>
-    'plugin:prettier/recommended',
-    <%_ } _%>
     <%_ if (test === 'webdriverio') { _%>
     'plugin:wdio/recommended',
     <%_ } _%>
-    'plugin:nuxt/recommended'
+    'plugin:nuxt/recommended',
+    <%_ if (prettier) { _%>
+    'prettier'
+    <%_ } _%>
   ],
   plugins: [
     <%_ if (test === 'webdriverio') { _%>

diff --git a/packages/cna-template/template/nuxt/package.js b/packages/cna-template/template/nuxt/package.js
@@ -46,7 +46,6 @@ module.exports = {
     }
     if (!prettier) {
       delete pkg.devDependencies['eslint-config-prettier']
-      delete pkg.devDependencies['eslint-plugin-prettier']
       delete pkg.devDependencies['stylelint-config-prettier']
       delete pkg.devDependencies.prettier
     }

diff --git a/packages/cna-template/template/nuxt/package.json b/packages/cna-template/template/nuxt/package.json
@@ -32,7 +32,6 @@
     "eslint": "^7.27.0",
     "eslint-config-prettier": "^8.3.0",
     "eslint-plugin-nuxt": "^2.0.0",
-    "eslint-plugin-prettier": "^3.4.0",
     "eslint-plugin-vue": "^7.9.0",
     "husky": "^6.0.0",
     "lint-staged": "^10.5.4",

diff --git a/packages/create-nuxt-app/test/snapshots/index.test.js.md b/packages/create-nuxt-app/test/snapshots/index.test.js.md
@@ -2093,7 +2093,6 @@ Generated by [AVA](https://avajs.dev).
         eslint: '^7.27.0',
         'eslint-config-prettier': '^8.3.0',
         'eslint-plugin-nuxt': '^2.0.0',
-        'eslint-plugin-prettier': '^3.4.0',
         'eslint-plugin-vue': '^7.9.0',
         husky: '^6.0.0',
         'lint-staged': '^10.5.4',
@@ -2286,7 +2285,6 @@ Generated by [AVA](https://avajs.dev).
       },
       devDependencies: {
         'eslint-config-prettier': '^8.3.0',
-        'eslint-plugin-prettier': '^3.4.0',
         prettier: '^2.3.0',
       },
       private: true,

diff --git a/packages/create-nuxt-app/test/snapshots/index.test.js.snap b/packages/create-nuxt-app/test/snapshots/index.test.js.snap