Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

feat(chore): included a dedicated option to show up envinfo #272

Merged
merged 6 commits into from
Jul 1, 2019

Conversation

jamesgeorge007
Copy link
Contributor

Fixes #240

Proposed API

create-nuxt-app --info

Environment Info:

  System:
    OS: Linux 4.18 Ubuntu 18.10 (Cosmic Cuttlefish)
    CPU: (4) x64 Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
  Binaries:
    Node: 8.11.4 - /usr/bin/node
    Yarn: 1.17.0-0 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 74.0.3729.157
    Firefox: 67.0.2
  npmGlobalPackages:
    create-nuxt-app: 2.8.0

improve flag check logic
dedicated method for envinfo logic
@2nthony
Copy link
Contributor

2nthony commented Jul 1, 2019

Maybe you can use the action second param options.info to instead of process.xxxxxxxxx

cli.action((outDir, options) => void)

But what this feature actually for?🤔

@jamesgeorge007
Copy link
Contributor Author

jamesgeorge007 commented Jul 1, 2019

Maybe you can use the action second param options.info to instead of process.xxxxxxxxx

@evillt I had given it a try, and it doesn't seem to work as expected.

But what this feature actually for? 🤔

The dedicated --info option is intended to simplify bug report submissions. There could be a section within the PR/issue template where in which the users can paste those results as provided by create-nuxt-app --info.

Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesgeorge007 Can we add some create-nuxt-app info as well, like version ?

I didn't notice npmGlobalPackages: ['create-nuxt-app'], sorry

@clarkdo clarkdo merged commit d2917a9 into nuxt:master Jul 1, 2019
@jamesgeorge007 jamesgeorge007 deleted the feat/info-option branch July 2, 2019 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print out local environment information on passing in a dedicated option (--info)
4 participants