This repository was archived by the owner on Mar 4, 2025. It is now read-only.
feat: upgrade Ava #284
Merged
feat: upgrade Ava #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pr, it looks good, the conflict needs to be resolved. |
Resolved conflicts |
|
@clarkdo : any thoughts on merging this? |
|
Sorry for the delay due to my device issue, I’ll check this as soon as it’s back to work |
|
@clarkdo it's cool 😎 |
|
Uhh. Hi! |
clarkdo
approved these changes
Jul 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.xto2.xwhich brings lots of breaking changes.