Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

feat: upgrade vuetify #297

Merged
merged 1 commit into from
Jul 26, 2019
Merged

feat: upgrade vuetify #297

merged 1 commit into from
Jul 26, 2019

Conversation

ricardogobbosouza
Copy link
Contributor

@ricardogobbosouza ricardogobbosouza commented Jul 24, 2019

Upgrade vuetify module to v1

Resolve #295
Resolve nuxt-community/vuetify-module#66

Copy link
Contributor

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardogobbosouza Have you been able to test if the generated project works ? Or at least just something that would prove everything is okay when creating new project with Vuetify option as UI framework.

@ricardogobbosouza
Copy link
Contributor Author

@kevinmarrec i tested the generated project and it works

Copy link
Contributor

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay LGTM

@kevinmarrec kevinmarrec requested a review from clarkdo July 24, 2019 22:12
@Lecraminos
Copy link

Lecraminos commented Jul 25, 2019

When populating a vanilla project with your changes, I receive some dependency warnings:

warning "@nuxtjs/vuetify > [email protected]" has unmet peer dependency "vue@^2.6.4".
warning "@nuxtjs/vuetify > [email protected]" has unmet peer dependency "vue-template-compiler@^2.5.0".
warning "@nuxtjs/vuetify > [email protected]" has incorrect peer dependency "vuetify@^1.3.0".

@clarkdo
Copy link
Member

clarkdo commented Jul 26, 2019

@Lecraminos Looks like it's a bug from yarn yarnpkg/yarn#5347, the warning is due to different version in modules:

Like nuxt -> vue@^2.6.10 and vuetify depends vue@^2.6.4 which are actually correct since they both support 2.6.10

@clarkdo clarkdo merged commit f735b63 into nuxt:master Jul 26, 2019
@ricardogobbosouza ricardogobbosouza deleted the feat-upgrade-vuetify branch July 26, 2019 21:57
@bujji1
Copy link

bujji1 commented Jul 31, 2019

Looks like some issue with the template . Please see the below error with latest version of Vuetify ( 2.0.3 ) and "nuxt": "^2.8.1",

ERROR  Could not compile template \\node_modules\\@nuxt\\vue-app\\template\\App.js: Cannot resolve "vuetify/src/stylus/main.styl" from "\vuetify\src\stylus\main.styl"

  at Promise.all.templateFiles.map (node_modules\@nuxt\builder\dist\builder.js:5945:17)

@ricardogobbosouza
Copy link
Contributor Author

@bujji1 vuetify 2 uses sass not styl

@bujji1
Copy link

bujji1 commented Jul 31, 2019

thank you @ricardogobbosouza for your response . yes , but upgrading to the latest throwing the above error .

Here are the steps to reproduce the above issue

1) npx create-nuxt-app sample1
2) ncu -u   ( To get the latest version of packages , You can install ncu using npm i -g npm-check-updates) 
3) npm install
4) npm run dev 

You will get the above issue . Thanks for checking .

@ricardogobbosouza
Copy link
Contributor Author

@bujji1 it works, please check version of create-nuxt-app

@bujji1
Copy link

bujji1 commented Jul 31, 2019

@ricardogobbosouza

With yarn create nuxt-app <my-project>
It worked just perfect . With yarn command it is using "@nuxtjs/vuetify": "^1.1.0", But with npm it is not

@ricardogobbosouza
Copy link
Contributor Author

@bujji1 what is the result?

npx create-nuxt-app --version

@bujji1
Copy link

bujji1 commented Jul 31, 2019

Thank You @ricardogobbosouza

create-nuxt-app/2.9.0 win32-x64 node-v10.15.1

Here is the package generated with npm command

  "dependencies": {
    "nuxt": "^1.0.0",
    "vuetify": "^0.17.3",
    "@nuxtjs/axios": "^5.0.0"
  },
  "devDependencies": {
    "cross-env": "^5.0.1",
    "stylus": "^0.54.5",
    "stylus-loader": "^3.0.1"
  }

with yarn

   "dependencies": {
    "nuxt": "^2.8.1"
  },
  "devDependencies": {
    "@nuxtjs/vuetify": "^1.1.0",
    "nodemon": "^1.19.1"
  }

@bujji1
Copy link

bujji1 commented Jul 31, 2019

Here is the log from npm and there are 9 vulnerabilities . The windows command is blocking and not proceeding any further after the last statement . After waiting for few minutes I am killing the process there and re running npm install again .

C:\Bujji\mygit\prod\chibu\client2>npx create-nuxt-app tk4
> Generating Nuxt.js project in C:\Bujji\mygit\prod\chibu\client2\tk4
? Project name tk4
? Project description My super-excellent Nuxt.js project
? Use a custom server framework none
? Use a custom UI framework vuetify
? Choose rendering mode Universal
? Use axios module yes
? Use eslint no
? Author name Bujji
? Choose a package manager npm
Initialized empty Git repository in C:/Bujji/mygit/prod/chibu/client2/tk4/.git/
npm WARN deprecated [email protected]: Deprecated. Please use https://github.com/webpack-contrib/mini-css-extract-plugin
npm WARN deprecated [email protected]: 'postcss-cssnext' has been deprecated in favor of 'postcss-preset-env'. Read more at https://moox.io/blog/deprecating-cssnext/
npm WARN deprecated [email protected]: Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools.
npm WARN deprecated [email protected]: Switch to the `bfj` package for fixes and new features!
npm WARN deprecated [email protected]: I wrote this module a very long time ago; you should use something else.
npm WARN deprecated [email protected]: Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools.

> [email protected] postinstall C:\Bujji\mygit\prod\chibu\client2\tk4\node_modules\core-js
> node scripts/postinstall || echo "ignore"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:
> https://opencollective.com/core-js
> https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)


> [email protected] postinstall C:\Bujji\mygit\prod\chibu\client2\tk4\node_modules\webpack\node_modules\uglifyjs-webpack-plugin
> node lib/post_install.js


> [email protected] postinstall C:\Bujji\mygit\prod\chibu\client2\tk4\node_modules\nuxt
> opencollective postinstall || exit 0


     *** Thank you for using nuxt! ***

Please consider donating to our open collective
     to help us maintain this package.

  https://opencollective.com/nuxtjs/donate

                    ***

npm WARN rollback Rolling back [email protected] failed (this is probably harmless): EPERM: operation not permitted, scandir 'C:\Bujji\mygit\prod\chibu\client2\tk4\node_modules\fsevents\node_modules'
npm WARN rollback Rolling back [email protected] failed (this is probably harmless): EPERM: operation not permitted, lstat 'C:\Bujji\mygit\prod\chibu\client2\tk4\node_modules\fsevents\node_modules'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN [email protected] requires a peer of ajv@^6.9.1 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})


added 1113 packages from 675 contributors and audited 10495 packages in 62.531s
found 9 vulnerabilities (5 moderate, 4 high)
  run `npm audit fix` to fix them, or `npm audit` for details

@bujji1
Copy link

bujji1 commented Jul 31, 2019

@ricardogobbosouza . It is my issue .
Some how there were multiple create-nuxt-app installed on my machine . I ran the below command and it cleaned the stuff .
npm uninstall -g create-nuxt-app

Now it is working just perfect even with npm . sorry for the wrong call .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create with Vuetify version 2.0.0 Upgrade create-nuxt-app
6 participants