-
-
Notifications
You must be signed in to change notification settings - Fork 427
feat: add typescript support using typescript-build #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ChangJoo-Park for working on this !
I let a little comment about package.json
.
Aside that, I think user should have the choice to use Runtime support, and the default layouts/pages/components should be converted in TypeScript (but i guess it's hard stuff doing it for every case depending of selected options)
I think so, Runtime support is important. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost perfect :)
all requests are done.
please review @kevinmarrec 🙇 |
@ChangJoo-Park Could you also take into account https://typescript.nuxtjs.org/guide/lint.html ?
I also think that for Nuxt TypeScript projects https://github.com/nuxt/create-nuxt-app/blob/master/template/_package.json#L123 ( |
Co-Authored-By: Kevin Marrec <[email protected]>
1,2. Changed
|
I'll check this :) |
@kevinmarrec Can you try lint on ubuntu? I tried my macbook (MacOS Catalina, Node.js v10), lint works well. |
It's cause before there wasn't template conditional check in Can you confirm that the template correctly has the right content with or without TypeScript when generating new project with your changes ? We can eventually add an entry in There are already 2 Vue files prevented to be linted cause there are using a template pattern Adding |
We also have to test TS integration against all UI & testing frameworks right? I can help out with Ava |
@vinayakkulkarni See my PR here: https://github.com/ChangJoo-Park/create-nuxt-app/pull/1 That covers a big number of them. After this gets merged I can submit a followup from that branch |
@ChangJoo-Park Can you fix the tests by following my last instructions ? Thanks ! |
Add jest.config.js
I try to fix out this lint failing, I didn't 😭 |
@ChangJoo-Park Seems the Some of them are passing, seems the others have been broken by some change ? |
@ChangJoo-Park Could you fix the conflicts ? :) |
Sure I'll fix it |
Thanks @atinux :) |
Whooo! |
Thanks! for Contributors |
Thank you for this PR, I was awaiting it with expectation. I have created the first app and it resembles very closely what I had already been using for myself. I've made a few suggestions in #448, including fixes to some problems that might arise after creating a new app. I'm leaving this comment here for anybody that might experience issues, in case it can help. |
I do not add any other typescript dependencies like
vue-property-decorator
andvue-function-api
. It may depends on users.and hard to decide add tsconfig.json by default. please give me a suggestions.