feat: add support for husky v6 #765
Conversation
packages/cna-template/template/frameworks/husky/.husky/pre-commit
Outdated
Show resolved
Hide resolved
| @@ -115,7 +115,8 @@ module.exports = [ | |||
| choices: [ | |||
| { name: 'jsconfig.json (Recommended for VS Code if you\'re not using typescript)', value: 'jsconfig.json' }, | |||
| { name: 'Semantic Pull Requests', value: 'semantic-pull-requests' }, | |||
| { name: 'Dependabot (For auto-updating dependencies, GitHub only)', value: 'dependabot' } | |||
| { name: 'Dependabot (For auto-updating dependencies, GitHub only)', value: 'dependabot' }, | |||
| { name: 'Git Hooks (via husky)', value: 'husky' } | |||
There was a problem hiding this comment.
I’m not sure if this is a good idea as actually we’re using husky only for lint in git but not provide any other special hooks.
There was a problem hiding this comment.
We use git-notify internally at GeoSpoc, and I thought adding husky as a devtool choice would provide devs with much more flexibility than just using husky for performing lint or test checks.
There was a problem hiding this comment.
I totally leave it upto you & the Nuxt team to decide on the approach, I'm just happy I get to contribute :)
There was a problem hiding this comment.
I think create-nuxt-app is more a nuxt template generater instead of generic application solution, so it makes sense to use lint-stage and husky to run vue and nuxt lint rules. And having hubsky as separeted may have some confilcts like:
- Select lint-stage/commitlint but not husky
- Select husky but not lint-stage/commitlint which is just adding husky as dep but no usage at all.
There was a problem hiding this comment.
@danielroe We could, but current pr is adding husky as a new selection Git Hooks (via husky)
There was a problem hiding this comment.
Sorry, I meant merge the previous PR #715 and then make this one about reconsidering the role of Husky. Your call though.
There was a problem hiding this comment.
@vinayakkulkarni Original pr has been merged, can you please update the pr add title ?
|
Will create new for husky v7 |
Husky is finally MIT again! Wo-Hoo 🥳
This PR will enable support for husky v6 out of the box.
@clarkdo: Pl review & you can successfully close #715 now :)