Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to latest @nuxt/module-builder #1439

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Previous versions of @nuxt/module-builder produced incorrect types for files in the runtime/ directory. Specifically, a .d.ts declaration paired with a .mjs file. This isn't correct - it should be either .d.mts and .mjs or .d.ts and .js.

For maximum compatibility, @nuxt/module-builder v0.8 switched to .js extension for files in runtime/ directory.

With the latest Nuxt, this is now an error that removes correct plugin injection types.

Related PRs: nuxt/nuxt#28480, nuxt/nuxt#28593
See also nuxt/nuxt#28672.

Copy link

Deploying nuxt-image with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: afd7163
Status:Β βœ…Β  Deploy successful!
Preview URL: https://3bac3a5a.nuxt-image.pages.dev
Branch Preview URL: https://update-module-builder.nuxt-image.pages.dev

View logs

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 62.26%. Comparing base (052f9a9) to head (afd7163).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1439   +/-   ##
=======================================
  Coverage   62.26%   62.26%           
=======================================
  Files          79       79           
  Lines        3599     3599           
  Branches      397      397           
=======================================
  Hits         2241     2241           
  Misses       1328     1328           
  Partials       30       30           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe merged commit 3104213 into main Aug 25, 2024
2 checks passed
@danielroe danielroe deleted the update-module-builder branch August 25, 2024 21:48
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants