Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ipx): use event.node.req and event.node.res #777

Merged
merged 1 commit into from
Mar 22, 2023
Merged

refactor(ipx): use event.node.req and event.node.res #777

merged 1 commit into from
Mar 22, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This swaps out deprecated property use for newer node.res and node.req objects.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working ipx labels Mar 21, 2023
@danielroe danielroe requested a review from pi0 March 21, 2023 12:19
@netlify
Copy link

netlify bot commented Mar 21, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-image-v1 canceled.

Name Link
🔨 Latest commit c914ec4
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-image-v1/deploys/6419a0c92d54f50008690487

@danielroe danielroe self-assigned this Mar 21, 2023
@pi0 pi0 changed the title fix(ipx): use node.req and node.res refactor(ipx): use event.node.req and event.node.res Mar 22, 2023
@pi0 pi0 merged commit da351a6 into main Mar 22, 2023
@pi0 pi0 deleted the fix/deprecated-node branch March 22, 2023 13:33
@pi0 pi0 mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
bug Something isn't working ipx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0