Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pkg): use esm build as main field #848

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix(pkg): use esm build as main field #848

merged 1 commit into from
Jun 6, 2023

Conversation

oraphadev
Copy link
Contributor

This PR should resolve #379
I'm open for any kind of feedback or improvement.

@netlify
Copy link

netlify bot commented Jun 5, 2023

👷 Deploy request for nuxt-image-v1 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d7b394c

@danielroe danielroe requested a review from pi0 June 6, 2023 08:29
@pi0 pi0 changed the title fix: ECMAScript as main fix(pkg): use esm build as main field Jun 6, 2023
pi0
pi0 approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as quick fix thanks.

We shall add exports field and once added, revert back main to cjs because all modern node runtimes will pick exports (also in CJS environment)

@pi0 pi0 merged commit 6e9298b into nuxt:main Jun 6, 2023
@pi0 pi0 mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skipping sharp dependency?
2 participants
@oraphadev @pi0