Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update og:image urls to use full path (+ add twitter:title and og:description) #1119

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Dec 21, 2022

resolves #1068

includes some changes in nuxt/content#1769 which can be reverted when that merges

Test tweet:

CleanShot 2022-12-21 at 16 50 31

@danielroe danielroe self-assigned this Dec 21, 2022
@vercel
Copy link

vercel bot commented Dec 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nuxt-com-theme ✅ Ready (Inspect) Visit Preview Dec 21, 2022 at 4:58PM (UTC)

@danielroe danielroe marked this pull request as ready for review December 21, 2022 16:51
@danielroe danielroe requested a review from atinux December 21, 2022 16:51
@vercel vercel bot temporarily deployed to Preview December 21, 2022 16:58 Inactive
@danielroe danielroe merged commit 31f630e into main Dec 21, 2022
@danielroe danielroe deleted the fix/og-images branch December 21, 2022 22:10
danielroe added a commit that referenced this pull request Dec 21, 2022
atinux added a commit that referenced this pull request Dec 22, 2022
* chore: use runtime env variables

* feat: use route-rules to implement current prerender strategy

* chore: don't prerender `/api/_content`

* fix: reorder route rules pending nitro fix

* fix: use consistent github token env variable

* fix: upgrade content

* fix: enable `stripQueryParameters`

* fix: update `og:image` urls to use full path (+ add `twitter:title` and `og:description`) (#1119)

* chore: remove todo

Co-authored-by: Sébastien Chopin <[email protected]>
danielroe added a commit that referenced this pull request Oct 18, 2023
danielroe added a commit that referenced this pull request Oct 18, 2023
* chore: use runtime env variables

* feat: use route-rules to implement current prerender strategy

* chore: don't prerender `/api/_content`

* fix: reorder route rules pending nitro fix

* fix: use consistent github token env variable

* fix: upgrade content

* fix: enable `stripQueryParameters`

* fix: update `og:image` urls to use full path (+ add `twitter:title` and `og:description`) (#1119)

* chore: remove todo

Co-authored-by: Sébastien Chopin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Twitter meta tags
2 participants