-
-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Explorer app module: remove Windows 7 specific code #15651
Milestone
Comments
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
…changer. Re nvaccess#15651. As NVDA no longer supports Windows 7, there is no need to keep Start menu search results name changer in File Explorera pp module.
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
…unds. Re nvaccess#15651. Remove Windows 7 Start menu prsentation and name/decription workaround.
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
…usBarText method. Re nvaccess#15651. Asume Windows 8.1 or later is in use when fetching File Explorer status bar text.
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
…te helper (private method). Re nvaccess#15651
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
…vaccess#15651. Gain focus event workarond for WorkerW is applicable when running on Windows 7 due to focus issue. Now that NVDA requires Windows 8.1 or later, there is no need for bulk of this event. Keep the class however in case WorkerW must be handled differently in the future.
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
…n and event method definition for readability. Re nvaccess#15651
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
…t info workaround. Re nvaccess#15651. Remove Windows 7 metadata edit field text info workarond as it no longer applies in Windows 8.1 and later.
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
josephsl
added a commit
to josephsl/nvda
that referenced
this issue
Oct 22, 2023
…e on method complexity. Re nvaccess#15651
5 tasks
seanbudd
pushed a commit
that referenced
this issue
Oct 23, 2023
Closes #15651 Summary of the issue: Remove Windows 7 (winVersion.WIN7_SP1) constant mentions from NVDA source code. Description of user facing changes None Description of development approach Mostly edited File Explorer app module and UIA objects code: Remove bulk of WorkerW, MetadataEditField, status bar fetcher, and Start menu/search suggestions handling on Windows 7 Removed text range exception check from UIA objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Stemming from #15647 and #15167:
Is your feature request related to a problem? Please describe.
As NVDA supports Windows 8.1 and later, there is no need to keep Windows 7 File Explorer specific code (Windows 8.0 code remains as it provides basis for Windows 8.1 File Explorer support).
Describe the solution you'd like
Remove the following code specific to Windows 7 File Explorer support:
And while not included in File Explorer app module, also remove a notice on UIA objects module where range fetcher freezes in Windows 7.
Describe alternatives you've considered
Leave code as is.
Additional context
This is one of the steps to be done before deprecating winVersion.WIN7_SP1 constant.
Thanks.
The text was updated successfully, but these errors were encountered: