Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore BRLTTY support #15652

Closed
LeonarddeR opened this issue Oct 19, 2023 · 0 comments · Fixed by #15658
Closed

Restore BRLTTY support #15652

LeonarddeR opened this issue Oct 19, 2023 · 0 comments · Fixed by #15658
Labels
bug/regression component/braille-display-drivers p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2024.1

Comments

@LeonarddeR
Copy link
Collaborator

Description of the issue

BRLTTY support was temporarily removed from Alpha builds since BRLTTY has no Python 3.11 compatible version of brlapi available. Attempts to use python's stable/minimal ABI failed.

Describe the solution you'd like

use a brlapi build specific for Python 3.11. Work is in progress for this, I'm about to file a pr upstream to provide this.
@LeonarddeR LeonarddeR added bug/regression p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority component/braille-display-drivers triaged Has been triaged, issue is waiting for implementation. labels Oct 19, 2023
@LeonarddeR LeonarddeR mentioned this issue Oct 20, 2023
Merged
5 tasks
seanbudd pushed a commit that referenced this issue Oct 26, 2023
@LeonarddeR
Restore support for brltty (#15658)
717f217 
Fixes #15652
See also nvaccess/nvda-misc-deps#28

Summary of the issue:
BRLTTY support was temporarily acknowledged as broken as part of #15544.

Description of user facing changes
None

Description of development approach
Update misc deps
Re-enable the brlapi test
Testing strategy:
Execute scons dist and run the generated NVDA distribution. Execute import brlapi from the Python Console.
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/regression component/braille-display-drivers p2 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2024.1
Development

Successfully merging a pull request may close this issue.

Restore support for brltty LeonarddeR/nvda
2 participants
@LeonarddeR @nvaccessAuto